From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB691C33CB3 for ; Tue, 14 Jan 2020 13:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96E7F214AF for ; Tue, 14 Jan 2020 13:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579010146; bh=1yUOzUoSxcZExOH/9FkbsG0uKOk9GKckSuGzrxAhpN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=0C9hCHyMHgUa4MLhpCRKbWUG4ecDZ3/UHvxM3G0lfiYz9k9UyS/o035M8AaUNRbau v5c3E4JJp3dBBAqnDbuoE9Q8QZHQj5pxrCTGyGQWRYObOzdovnaM3cXo3ivUM2y6U3 /ktf9JdUs7KSMn+XYSi4G6LyXOmx3gC2k6gT9ZXY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728874AbgANNzp (ORCPT ); Tue, 14 Jan 2020 08:55:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:43568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbgANNzp (ORCPT ); Tue, 14 Jan 2020 08:55:45 -0500 Received: from cakuba.hsd1.ca.comcast.net (c-73-93-4-247.hsd1.ca.comcast.net [73.93.4.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA8522467A; Tue, 14 Jan 2020 13:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579010145; bh=1yUOzUoSxcZExOH/9FkbsG0uKOk9GKckSuGzrxAhpN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y/OHm3zVJP77IeFzNoTtCjaV4OMo99jbKwlrOUlnf74lwnac0v9y+KRU8MT/8n/1U v1vikP/x83NJ81KIqu9FjDc8BC5HTVi4vL06g1v+ntBL5f0MJEBv0uSh9lzruZIGrM jq/Yhgng2P3+H4sqZMZnw4xSFckrSrVxa7SudB0Q= Date: Tue, 14 Jan 2020 05:55:44 -0800 From: Jakub Kicinski To: Nikolay Aleksandrov Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, davem@davemloft.net, bridge@lists.linux-foundation.org, "dsahern@gmail.com" Subject: Re: [PATCH net-next 3/8] net: bridge: vlan: add rtm definitions and dump support Message-ID: <20200114055544.77a7806f@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20200113155233.20771-4-nikolay@cumulusnetworks.com> References: <20200113155233.20771-1-nikolay@cumulusnetworks.com> <20200113155233.20771-4-nikolay@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 13 Jan 2020 17:52:28 +0200, Nikolay Aleksandrov wrote: > +static int br_vlan_rtm_dump(struct sk_buff *skb, struct netlink_callback *cb) > +{ > + int idx = 0, err = 0, s_idx = cb->args[0]; > + struct net *net = sock_net(skb->sk); > + struct br_vlan_msg *bvm; > + struct net_device *dev; > + > + if (cb->nlh->nlmsg_len < nlmsg_msg_size(sizeof(*bvm))) { I wonder if it'd be useful to make this a strict != check? At least when strict validation is on? Perhaps we'll one day want to extend the request? > + NL_SET_ERR_MSG_MOD(cb->extack, "Invalid header for vlan dump request"); > + return -EINVAL; > + }