Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/1] pull request for net: batman-adv 2020-01-14
@ 2020-01-14 14:16 Simon Wunderlich
  2020-01-14 14:16 ` [PATCH 1/1] batman-adv: Fix DAT candidate selection on little endian systems Simon Wunderlich
  2020-01-15 21:45 ` [PATCH 0/1] pull request for net: batman-adv 2020-01-14 David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Simon Wunderlich @ 2020-01-14 14:16 UTC (permalink / raw)
  To: davem; +Cc: netdev, b.a.t.m.a.n, Simon Wunderlich

Hi David,

here is a bugfix which we would like to have integrated into net.

Please pull or let me know of any problem!

Thank you,
      Simon

The following changes since commit 40e220b4218bb3d278e5e8cc04ccdfd1c7ff8307:

  batman-adv: Avoid free/alloc race when handling OGM buffer (2019-10-13 21:00:07 +0200)

are available in the Git repository at:

  git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20200114

for you to fetch changes up to 4cc4a1708903f404d2ca0dfde30e71e052c6cbc9:

  batman-adv: Fix DAT candidate selection on little endian systems (2019-11-28 12:48:59 +0100)

----------------------------------------------------------------
Here is a batman-adv bugfix:

 - Fix DAT candidate selection on little endian systems,
   by Sven Eckelmann

----------------------------------------------------------------
Sven Eckelmann (1):
      batman-adv: Fix DAT candidate selection on little endian systems

 net/batman-adv/distributed-arp-table.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] batman-adv: Fix DAT candidate selection on little endian systems
  2020-01-14 14:16 [PATCH 0/1] pull request for net: batman-adv 2020-01-14 Simon Wunderlich
@ 2020-01-14 14:16 ` Simon Wunderlich
  2020-01-15 21:45 ` [PATCH 0/1] pull request for net: batman-adv 2020-01-14 David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Wunderlich @ 2020-01-14 14:16 UTC (permalink / raw)
  To: davem; +Cc: netdev, b.a.t.m.a.n, Sven Eckelmann, Simon Wunderlich

From: Sven Eckelmann <sven@narfation.org>

The distributed arp table is using a DHT to store and retrieve MAC address
information for an IP address. This is done using unicast messages to
selected peers. The potential peers are looked up using the IP address and
the VID.

While the IP address is always stored in big endian byte order, this is not
the case of the VID. It can (depending on the host system) either be big
endian or little endian. The host must therefore always convert it to big
endian to ensure that all devices calculate the same peers for the same
lookup data.

Fixes: be1db4f6615b ("batman-adv: make the Distributed ARP Table vlan aware")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/distributed-arp-table.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
index b0af3a11d406..ec7bf5a4a9fc 100644
--- a/net/batman-adv/distributed-arp-table.c
+++ b/net/batman-adv/distributed-arp-table.c
@@ -285,6 +285,7 @@ static u32 batadv_hash_dat(const void *data, u32 size)
 	u32 hash = 0;
 	const struct batadv_dat_entry *dat = data;
 	const unsigned char *key;
+	__be16 vid;
 	u32 i;
 
 	key = (const unsigned char *)&dat->ip;
@@ -294,7 +295,8 @@ static u32 batadv_hash_dat(const void *data, u32 size)
 		hash ^= (hash >> 6);
 	}
 
-	key = (const unsigned char *)&dat->vid;
+	vid = htons(dat->vid);
+	key = (__force const unsigned char *)&vid;
 	for (i = 0; i < sizeof(dat->vid); i++) {
 		hash += key[i];
 		hash += (hash << 10);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/1] pull request for net: batman-adv 2020-01-14
  2020-01-14 14:16 [PATCH 0/1] pull request for net: batman-adv 2020-01-14 Simon Wunderlich
  2020-01-14 14:16 ` [PATCH 1/1] batman-adv: Fix DAT candidate selection on little endian systems Simon Wunderlich
@ 2020-01-15 21:45 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-01-15 21:45 UTC (permalink / raw)
  To: sw; +Cc: netdev, b.a.t.m.a.n

From: Simon Wunderlich <sw@simonwunderlich.de>
Date: Tue, 14 Jan 2020 15:16:45 +0100

> here is a bugfix which we would like to have integrated into net.
> 
> Please pull or let me know of any problem!

Pulled, thanks Simon.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 14:16 [PATCH 0/1] pull request for net: batman-adv 2020-01-14 Simon Wunderlich
2020-01-14 14:16 ` [PATCH 1/1] batman-adv: Fix DAT candidate selection on little endian systems Simon Wunderlich
2020-01-15 21:45 ` [PATCH 0/1] pull request for net: batman-adv 2020-01-14 David Miller

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git