From: David Miller <davem@davemloft.net>
To: ms@dev.tdt.de
Cc: kubakici@wp.pl, khc@pm.waw.pl, linux-x25@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] wan/hdlc_x25: make lapb params configurable
Date: Wed, 15 Jan 2020 13:43:39 -0800 (PST) [thread overview]
Message-ID: <20200115.134339.199447041886048873.davem@davemloft.net> (raw)
In-Reply-To: <20200114140223.22446-1-ms@dev.tdt.de>
From: Martin Schiller <ms@dev.tdt.de>
Date: Tue, 14 Jan 2020 15:02:22 +0100
> This enables you to configure mode (DTE/DCE), Modulo, Window, T1, T2, N2 via
> sethdlc (which needs to be patched as well).
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
I don't know how wise it is to add new ioctls to this old driver.
Also, none of these ioctls even have COMPAT handling so they will
never work from a 32-bit binary running on a 64-bit kernel for
example.
Also:
> +static struct x25_state* state(hdlc_device *hdlc)
It is always "type *func" never "type* func"
> static int x25_open(struct net_device *dev)
> {
> int result;
> + hdlc_device *hdlc = dev_to_hdlc(dev);
> + struct lapb_parms_struct params;
> static const struct lapb_register_struct cb = {
Please make this reverse christmas tree ordered.
> @@ -186,6 +217,9 @@ static struct hdlc_proto proto = {
>
> static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
> {
> + x25_hdlc_proto __user *x25_s = ifr->ifr_settings.ifs_ifsu.x25;
> + const size_t size = sizeof(x25_hdlc_proto);
> + x25_hdlc_proto new_settings;
> hdlc_device *hdlc = dev_to_hdlc(dev);
> int result;
Likewise.
next prev parent reply other threads:[~2020-01-15 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 14:02 [PATCH v2 1/2] wan/hdlc_x25: make lapb params configurable Martin Schiller
2020-01-14 14:02 ` [PATCH v2 2/2] wan/hdlc_x25: fix skb handling Martin Schiller
2020-01-15 21:43 ` David Miller [this message]
2020-01-16 6:03 ` [PATCH v2 1/2] wan/hdlc_x25: make lapb params configurable Martin Schiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115.134339.199447041886048873.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kubakici@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).