netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, juvanham@gmail.com
Subject: Re: [PATCH net] macvlan: use skb_reset_mac_header() in macvlan_queue_xmit()
Date: Thu, 16 Jan 2020 04:14:02 -0800 (PST)	[thread overview]
Message-ID: <20200116.041402.757321430890945981.davem@davemloft.net> (raw)
In-Reply-To: <20200114210035.65042-1-edumazet@google.com>

From: Eric Dumazet <edumazet@google.com>
Date: Tue, 14 Jan 2020 13:00:35 -0800

> I missed the fact that macvlan_broadcast() can be used both
> in RX and TX.
> 
> skb_eth_hdr() makes only sense in TX paths, so we can not
> use it blindly in macvlan_broadcast()
> 
> Fixes: 96cc4b69581d ("macvlan: do not assume mac_header is set in macvlan_broadcast()")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Jurgen Van Ham <juvanham@gmail.com>

Applied and queued up for -stable, thanks Eric.

      parent reply	other threads:[~2020-01-16 12:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 21:00 [PATCH net] macvlan: use skb_reset_mac_header() in macvlan_queue_xmit() Eric Dumazet
2020-01-15  1:38 ` Matteo Croce
2020-01-16 12:14 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116.041402.757321430890945981.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=juvanham@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).