From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B559C33CB1 for ; Thu, 16 Jan 2020 12:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C43A208C3 for ; Thu, 16 Jan 2020 12:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbgAPM0W (ORCPT ); Thu, 16 Jan 2020 07:26:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38036 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbgAPM0W (ORCPT ); Thu, 16 Jan 2020 07:26:22 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9AEB515B52F02; Thu, 16 Jan 2020 04:26:19 -0800 (PST) Date: Thu, 16 Jan 2020 04:26:17 -0800 (PST) Message-Id: <20200116.042617.270163669922168566.davem@davemloft.net> To: tanhuazhong@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com, jakub.kicinski@netronome.com, linyunsheng@huawei.com Subject: Re: [PATCH net] net: hns3: pad the short frame before sending to the hardware From: David Miller In-Reply-To: <1579056405-30385-1-git-send-email-tanhuazhong@huawei.com> References: <1579056405-30385-1-git-send-email-tanhuazhong@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 16 Jan 2020 04:26:21 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Huazhong Tan Date: Wed, 15 Jan 2020 10:46:45 +0800 > From: Yunsheng Lin > > The hardware can not handle short frames below or equal to 32 > bytes according to the hardware user manual, and it will trigger > a RAS error when the frame's length is below 33 bytes. > > This patch pads the SKB when skb->len is below 33 bytes before > sending it to hardware. > > Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") > Signed-off-by: Yunsheng Lin > Signed-off-by: Huazhong Tan Applied and queued up for -stable.