From: Jakub Kicinski <kuba@kernel.org>
To: sunil.kovvuri@gmail.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, mkubecek@suse.cz,
Sunil Goutham <sgoutham@marvell.com>
Subject: Re: [PATCH v4 03/17] octeontx2-pf: Attach NIX and NPA block LFs
Date: Tue, 21 Jan 2020 08:00:38 -0800 [thread overview]
Message-ID: <20200121080038.0fe6a819@cakuba> (raw)
In-Reply-To: <1579612911-24497-4-git-send-email-sunil.kovvuri@gmail.com>
On Tue, 21 Jan 2020 18:51:37 +0530, sunil.kovvuri@gmail.com wrote:
> +int otx2_config_npa(struct otx2_nic *pfvf)
> +{
> + struct otx2_qset *qset = &pfvf->qset;
> + struct npa_lf_alloc_req *npalf;
> + struct otx2_hw *hw = &pfvf->hw;
> + int aura_cnt, err;
> +
> + /* Pool - Stack of free buffer pointers
> + * Aura - Alloc/frees pointers from/to pool for NIX DMA.
> + */
> +
> + if (!hw->pool_cnt)
> + return -EINVAL;
> +
> + qset->pool = devm_kzalloc(pfvf->dev, sizeof(struct otx2_pool) *
> + hw->pool_cnt, GFP_KERNEL);
> + if (!qset->pool)
> + return -ENOMEM;
> +
> + /* Get memory to put this msg */
> + npalf = otx2_mbox_alloc_msg_npa_lf_alloc(&pfvf->mbox);
> + if (!npalf)
> + return -ENOMEM;
> +
> + /* Set aura and pool counts */
> + npalf->nr_pools = hw->pool_cnt;
> + aura_cnt = ilog2(roundup_pow_of_two(hw->pool_cnt));
> + npalf->aura_sz = (aura_cnt >= ilog2(128)) ? (aura_cnt - 6) : 1;
> +
> + err = otx2_sync_mbox_msg(&pfvf->mbox);
> + if (err)
> + return err;
> + return 0;
return otx2_sync..
directly
> +}
> +static int otx2_realloc_msix_vectors(struct otx2_nic *pf)
> +{
> + struct otx2_hw *hw = &pf->hw;
> + int num_vec, err;
> +
> + /* NPA interrupts are inot registered, so alloc only
> + * upto NIX vector offset.
> + */
> + num_vec = hw->nix_msixoff;
> +#define NIX_LF_CINT_VEC_START 0x40
> + num_vec += NIX_LF_CINT_VEC_START + hw->max_queues;
> +
> + otx2_disable_mbox_intr(pf);
> + pci_free_irq_vectors(hw->pdev);
> + pci_free_irq_vectors(hw->pdev);
> + err = pci_alloc_irq_vectors(hw->pdev, num_vec, num_vec, PCI_IRQ_MSIX);
> + if (err < 0) {
> + dev_err(pf->dev, "%s: Failed to realloc %d IRQ vectors\n",
> + __func__, num_vec);
> + return err;
> + }
> +
> + err = otx2_register_mbox_intr(pf, false);
> + if (err)
> + return err;
> + return 0;
> +}
ditto, please fix this everywhere in the submission
next prev parent reply other threads:[~2020-01-21 16:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:21 [PATCH v4 00/17] octeontx2-pf: Add network driver for physical function sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 01/17] octeontx2-pf: Add Marvell OcteonTX2 NIC driver sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski
2020-01-21 13:21 ` [PATCH v4 02/17] octeontx2-pf: Mailbox communication with AF sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski
2020-01-22 19:27 ` Sunil Kovvuri
2020-01-23 14:14 ` Jakub Kicinski
2020-01-24 8:33 ` Maciej Fijalkowski
2020-01-24 17:15 ` Sunil Kovvuri
2020-01-21 13:21 ` [PATCH v4 03/17] octeontx2-pf: Attach NIX and NPA block LFs sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski [this message]
2020-01-22 19:27 ` Sunil Kovvuri
2020-01-21 13:21 ` [PATCH v4 04/17] octeontx2-pf: Initialize and config queues sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski
2020-01-22 19:29 ` Sunil Kovvuri
2020-01-23 14:20 ` Jakub Kicinski
2020-01-24 11:21 ` Sunil Kovvuri
2020-01-21 13:21 ` [PATCH v4 05/17] octeontx2-pf: Setup interrupts and NAPI handler sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 06/17] octeontx2-pf: Receive packet handling support sunil.kovvuri
2020-01-21 16:33 ` Jakub Kicinski
2020-01-22 19:34 ` Sunil Kovvuri
2020-01-24 10:14 ` Maciej Fijalkowski
2020-01-21 13:21 ` [PATCH v4 07/17] octeontx2-pf: Add packet transmission support sunil.kovvuri
2020-01-21 16:54 ` Jakub Kicinski
2020-01-22 19:50 ` Sunil Kovvuri
2020-01-23 14:24 ` Jakub Kicinski
2020-01-21 13:21 ` [PATCH v4 08/17] octeontx2-pf: Register and handle link notifications sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 09/17] octeontx2-pf: MTU, MAC and RX mode config support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 10/17] octeontx2-pf: Error handling support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 11/17] octeontx2-pf: Receive side scaling support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 12/17] octeontx2-pf: TCP segmentation offload support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 13/17] octeontx2-pf: Add ndo_get_stats64 sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 14/17] octeontx2-pf: Add basic ethtool support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 15/17] octeontx2-pf: ethtool RSS config support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 16/17] Documentation: net: octeontx2: Add RVU HW and drivers overview sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 17/17] MAINTAINERS: Add entry for Marvell OcteonTX2 Physical Function driver sunil.kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121080038.0fe6a819@cakuba \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=sunil.kovvuri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).