From: Jiri Pirko <jiri@resnulli.us>
To: Pavan Chebbi <pavan.chebbi@broadcom.com>
Cc: davem@davemloft.net, michael.chan@broadcom.com,
vasundhara-v.volam@broadcom.com, netdev@vger.kernel.org,
jiri@mellanox.com
Subject: Re: [PATCH] devlink: Add enable_ecn boolean generic parameter
Date: Wed, 22 Jan 2020 14:32:19 +0100 [thread overview]
Message-ID: <20200122133219.GA2196@nanopsycho> (raw)
In-Reply-To: <1579689646-13123-1-git-send-email-pavan.chebbi@broadcom.com>
Wed, Jan 22, 2020 at 11:40:46AM CET, pavan.chebbi@broadcom.com wrote:
>enable_ecn - Enables Explicit Congestion Notification
>characteristic of the device.
>
>Cc: Jiri Pirko <jiri@mellanox.com>
>Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
NAK.
You are missing at least:
documentation
driver user
>---
> include/net/devlink.h | 4 ++++
> net/core/devlink.c | 5 +++++
> 2 files changed, 9 insertions(+)
>
>diff --git a/include/net/devlink.h b/include/net/devlink.h
>index 5e46c24..52315dd 100644
>--- a/include/net/devlink.h
>+++ b/include/net/devlink.h
>@@ -403,6 +403,7 @@ enum devlink_param_generic_id {
> DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY,
> DEVLINK_PARAM_GENERIC_ID_RESET_DEV_ON_DRV_PROBE,
> DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE,
>+ DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN,
>
> /* add new param generic ids above here*/
> __DEVLINK_PARAM_GENERIC_ID_MAX,
>@@ -440,6 +441,9 @@ enum devlink_param_generic_id {
> #define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME "enable_roce"
> #define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE DEVLINK_PARAM_TYPE_BOOL
>
>+#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME "enable_ecn"
>+#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE DEVLINK_PARAM_TYPE_BOOL
>+
> #define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate) \
> { \
> .id = DEVLINK_PARAM_GENERIC_ID_##_id, \
>diff --git a/net/core/devlink.c b/net/core/devlink.c
>index 64367ee..298dcd1 100644
>--- a/net/core/devlink.c
>+++ b/net/core/devlink.c
>@@ -3011,6 +3011,11 @@ static int devlink_nl_cmd_flash_update(struct sk_buff *skb,
> .name = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME,
> .type = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE,
> },
>+ {
>+ .id = DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN,
>+ .name = DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME,
>+ .type = DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE,
>+ },
> };
>
> static int devlink_param_generic_verify(const struct devlink_param *param)
>--
>1.8.3.1
>
prev parent reply other threads:[~2020-01-22 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 10:40 [PATCH] devlink: Add enable_ecn boolean generic parameter Pavan Chebbi
2020-01-22 13:32 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122133219.GA2196@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).