From: gautamramk@gmail.com
To: netdev@vger.kernel.org
Cc: "Mohit P. Tahiliani" <tahiliani@nitk.edu.in>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"David S . Miller" <davem@davemloft.net>,
"Dave Taht" <dave.taht@gmail.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Leslie Monis" <lesliemonis@gmail.com>,
"Gautam Ramakrishnan" <gautamramk@gmail.com>
Subject: [PATCH net-next v7 04/10] pie: use u8 instead of bool in pie_vars
Date: Wed, 22 Jan 2020 23:52:27 +0530 [thread overview]
Message-ID: <20200122182233.3940-5-gautamramk@gmail.com> (raw)
In-Reply-To: <20200122182233.3940-1-gautamramk@gmail.com>
From: "Mohit P. Tahiliani" <tahiliani@nitk.edu.in>
Linux best practice recommends using u8 for true/false values in
structures.
Signed-off-by: Mohit P. Tahiliani <tahiliani@nitk.edu.in>
Signed-off-by: Leslie Monis <lesliemonis@gmail.com>
Signed-off-by: Gautam Ramakrishnan <gautamramk@gmail.com>
---
include/net/pie.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/pie.h b/include/net/pie.h
index 397c7abf0879..f9c6a44bdb0c 100644
--- a/include/net/pie.h
+++ b/include/net/pie.h
@@ -21,8 +21,8 @@ struct pie_params {
u32 limit; /* number of packets that can be enqueued */
u32 alpha; /* alpha and beta are between 0 and 32 */
u32 beta; /* and are used for shift relative to 1 */
- bool ecn; /* true if ecn is enabled */
- bool bytemode; /* to scale drop early prob based on pkt size */
+ u8 ecn; /* true if ecn is enabled */
+ u8 bytemode; /* to scale drop early prob based on pkt size */
u8 dq_rate_estimator; /* to calculate delay using Little's law */
};
--
2.17.1
next prev parent reply other threads:[~2020-01-22 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 18:22 [PATCH net-next v7 00/10] net: sched: add Flow Queue PIE packet scheduler gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 01/10] net: sched: pie: move common code to pie.h gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 02/10] pie: use U64_MAX to denote (2^64 - 1) gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 03/10] pie: rearrange macros in order of length gautamramk
2020-01-22 18:22 ` gautamramk [this message]
2020-01-22 18:22 ` [PATCH net-next v7 05/10] pie: rearrange structure members and their initializations gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 06/10] pie: improve comments and commenting style gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 07/10] net: sched: pie: fix commenting gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 08/10] net: sched: pie: fix alignment in struct instances gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 09/10] net: sched: pie: export symbols to be reused by FQ-PIE gautamramk
2020-01-22 18:22 ` [PATCH net-next v7 10/10] net: sched: add Flow Queue PIE packet scheduler gautamramk
2020-01-23 10:39 ` [PATCH net-next v7 00/10] " David Miller
2020-01-23 16:14 ` Gautam Ramakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122182233.3940-5-gautamramk@gmail.com \
--to=gautamramk@gmail.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=lesliemonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tahiliani@nitk.edu.in \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).