From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Luigi Rizzo <lrizzo@google.com>, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net-core: remove unnecessary ETHTOOL_GCHANNELS initialization
Date: Thu, 23 Jan 2020 21:01:06 +0100 [thread overview]
Message-ID: <20200123200106.GU22304@unicorn.suse.cz> (raw)
In-Reply-To: <CAMOZA0L7+ugo7e=VeiGUc49fyNTxr0HmU4cuM8jHfRO3OMYuXw@mail.gmail.com>
On Thu, Jan 23, 2020 at 09:47:56AM -0800, Luigi Rizzo wrote:
>
> For the same reason though (comply with the header) we might perhaps
> want to replace with cmd with ETHTOOL_SCHANNELS before actually
> calling dev->ethtool_ops->set_channels()
>
> (I realize this is not particularly important)
That structure is filled by copy_from_user() and the structure passed by
userspace already has .cmd = ETHTOOL_SCHANNELS - otherwise we wouldn't
end up in ethtool_set_channels().
Michal
prev parent reply other threads:[~2020-01-23 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 22:33 [PATCH] net-core: remove unnecessary ETHTOOL_GCHANNELS initialization Luigi Rizzo
2020-01-22 23:47 ` Andrew Lunn
2020-01-23 0:18 ` Luigi Rizzo
2020-01-23 8:28 ` Michal Kubecek
2020-01-23 8:40 ` Michal Kubecek
2020-01-23 17:47 ` Luigi Rizzo
2020-01-23 20:01 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123200106.GU22304@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=lrizzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).