From: kbuild test robot <lkp@intel.com>
To: Martin Varghese <martinvarghesenokia@gmail.com>
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
davem@davemloft.net, corbet@lwn.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, scott.drennan@nokia.com,
jbenc@redhat.com, martin.varghese@nokia.com
Subject: Re: [PATCH net-next v4 1/2] net: UDP tunnel encapsulation module for
Date: Fri, 24 Jan 2020 17:41:28 +0800 [thread overview]
Message-ID: <202001241737.ld1pMSTE%lkp@intel.com> (raw)
In-Reply-To: <d08b50ebd2f088b099fdaaaac2f9115d6e4dda5c.1579624762.git.martin.varghese@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 3116 bytes --]
Hi Martin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v5.5-rc7 next-20200123]
[cannot apply to ipvs/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Martin-Varghese/Bare-UDP-L3-Encapsulation-Module/20200124-103044
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9bbc8be29d66cc34b650510f2c67b5c55235fe5d
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers//net/bareudp.c: In function 'bareudp_fill_metadata_dst':
>> drivers//net/bareudp.c:455:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
return ret;
^~~
vim +/ret +455 drivers//net/bareudp.c
413
414 static int bareudp_fill_metadata_dst(struct net_device *dev,
415 struct sk_buff *skb)
416 {
417 struct ip_tunnel_info *info = skb_tunnel_info(skb);
418 struct bareudp_dev *bareudp = netdev_priv(dev);
419 bool use_cache = ip_tunnel_dst_cache_usable(skb, info);
420 int ret;
421
422 if (ip_tunnel_info_af(info) == AF_INET) {
423 struct rtable *rt;
424 struct flowi4 fl4;
425
426 rt = iptunnel_get_rt(skb, dev, bareudp->net, &fl4, info,
427 use_cache);
428 if (IS_ERR(rt))
429 return PTR_ERR(rt);
430
431 ip_rt_put(rt);
432 info->key.u.ipv4.src = fl4.saddr;
433 #if IS_ENABLED(CONFIG_IPV6)
434 } else if (ip_tunnel_info_af(info) == AF_INET6) {
435 struct dst_entry *dst;
436 struct flowi6 fl6;
437 struct socket *sock = rcu_dereference(bareudp->sock);
438
439 dst = ip6tunnel_get_dst(skb, dev, bareudp->net, sock, &fl6,
440 info, use_cache);
441 if (IS_ERR(dst))
442 return PTR_ERR(dst);
443
444 dst_release(dst);
445 info->key.u.ipv6.src = fl6.saddr;
446 #endif
447 } else {
448 return -EINVAL;
449 }
450
451 info->key.tp_src = udp_flow_src_port(bareudp->net, skb,
452 bareudp->sport_min,
453 USHRT_MAX, true);
454 info->key.tp_dst = bareudp->port;
> 455 return ret;
456 }
457
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52846 bytes --]
next prev parent reply other threads:[~2020-01-24 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 17:48 [PATCH net-next v4 0/2] Bare UDP L3 Encapsulation Module Martin Varghese
2020-01-21 17:50 ` [PATCH net-next v4 1/2] net: UDP tunnel encapsulation module for Martin Varghese
2020-01-22 18:29 ` Willem de Bruijn
2020-01-23 9:59 ` Martin Varghese
2020-01-23 14:50 ` Martin Varghese
2020-01-24 9:41 ` kbuild test robot [this message]
2020-01-24 13:30 ` kbuild test robot
2020-01-21 17:51 ` [PATCH net-next v4 2/2] net: Special handling for IP & MPLS Martin Varghese
2020-01-22 18:30 ` Willem de Bruijn
2020-01-23 10:00 ` Martin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001241737.ld1pMSTE%lkp@intel.com \
--to=lkp@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=martin.varghese@nokia.com \
--cc=martinvarghesenokia@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=scott.drennan@nokia.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).