From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E7AC2D0DB for ; Fri, 31 Jan 2020 18:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C778E20663 for ; Fri, 31 Jan 2020 18:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580494059; bh=P04dmKf3OT4D1hSsCAL27hf8NQtQTt7Ymo69pvNsmEM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VEJVa3a3+TmSW1Ur7Ef2+cYeALunLGFmAf4K28Ko6Iixet1qDQaTtFCB47T05nbww vsMBXo9bRQ0J+TNtZaA/zMTyJlv1UCyxveRKl4/i+gSLaHoZju5AHPjawqHpPlXKov fJgFCWUfoFJe4LTIYyXDASfQVuTBYAxBRWIilT08= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727321AbgAaSHj (ORCPT ); Fri, 31 Jan 2020 13:07:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:59656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726712AbgAaSHi (ORCPT ); Fri, 31 Jan 2020 13:07:38 -0500 Received: from cakuba.hsd1.ca.comcast.net (unknown [199.201.64.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F380B20CC7; Fri, 31 Jan 2020 18:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580494058; bh=P04dmKf3OT4D1hSsCAL27hf8NQtQTt7Ymo69pvNsmEM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IF1kyBuAz2aBw4WixsVL/9lALEVgJsAaWv0Wm+AEzpWHE8zG5xr5Zfrs9tXINcmR1 rK+lsEkOp2wFTzgpamMJWUOAEHF2KngenJZM7b+mLpkvNf1Ul/RMzZVBEmhluIfqIN 8YNLy8nJ21vMTPfu6PYUUL+jHQJecbKQONEeIwf0= Date: Fri, 31 Jan 2020 10:07:36 -0800 From: Jakub Kicinski To: Jacob Keller Cc: netdev@vger.kernel.org, jiri@resnulli.us, valex@mellanox.com, linyunsheng@huawei.com, lihong.yang@intel.com Subject: Re: [PATCH 03/15] devlink: add operation to take an immediate snapshot Message-ID: <20200131100736.54a7deb7@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20200130225913.1671982-4-jacob.e.keller@intel.com> References: <20200130225913.1671982-1-jacob.e.keller@intel.com> <20200130225913.1671982-4-jacob.e.keller@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 30 Jan 2020 14:58:58 -0800, Jacob Keller wrote: > Add a new devlink command, DEVLINK_CMD_REGION_TAKE_SNAPSHOT. This > command is intended to enable userspace to request an immediate snapshot > of a region. > > Regions can enable support for requestable snapshots by implementing the > snapshot callback function in the region's devlink_region_ops structure. > > Implementations of this function callback should capture an immediate > copy of the data and return it and its destructor in the function > parameters. The core devlink code will generate a snapshot ID and create > the new snapshot while holding the devlink instance lock. > > Signed-off-by: Jacob Keller Reviewed-by: Jakub Kicinski