* [PATCH net] qed: Fix a error code in qed_hw_init()
@ 2020-01-31 5:03 Dan Carpenter
2020-02-01 19:41 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-01-31 5:03 UTC (permalink / raw)
To: Ariel Elior, Michal Kalderon
Cc: GR-everest-linux-l2, David S. Miller, netdev, kernel-janitors
If the qed_fw_overlay_mem_alloc() then we should return -ENOMEM instead
of success.
Fixes: 30d5f85895fa ("qed: FW 8.42.2.0 Add fw overlay feature")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/qlogic/qed/qed_dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index 7912911337d4..03bdd2e26329 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -3114,6 +3114,7 @@ int qed_hw_init(struct qed_dev *cdev, struct qed_hw_init_params *p_params)
if (!p_hwfn->fw_overlay_mem) {
DP_NOTICE(p_hwfn,
"Failed to allocate fw overlay memory\n");
+ rc = -ENOMEM;
goto load_err;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] qed: Fix a error code in qed_hw_init()
2020-01-31 5:03 [PATCH net] qed: Fix a error code in qed_hw_init() Dan Carpenter
@ 2020-02-01 19:41 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-02-01 19:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ariel Elior, Michal Kalderon, GR-everest-linux-l2,
David S. Miller, netdev, kernel-janitors
On Fri, 31 Jan 2020 08:03:26 +0300, Dan Carpenter wrote:
> If the qed_fw_overlay_mem_alloc() then we should return -ENOMEM instead
> of success.
>
> Fixes: 30d5f85895fa ("qed: FW 8.42.2.0 Add fw overlay feature")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-01 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 5:03 [PATCH net] qed: Fix a error code in qed_hw_init() Dan Carpenter
2020-02-01 19:41 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).