From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FA2C3524E for ; Mon, 3 Feb 2020 09:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A548F20658 for ; Mon, 3 Feb 2020 09:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbgBCJWv (ORCPT ); Mon, 3 Feb 2020 04:22:51 -0500 Received: from mga11.intel.com ([192.55.52.93]:60194 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbgBCJWv (ORCPT ); Mon, 3 Feb 2020 04:22:51 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 01:22:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,397,1574150400"; d="scan'208";a="263351396" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2020 01:22:45 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1iyXwM-0004Pw-8z; Mon, 03 Feb 2020 11:22:46 +0200 Date: Mon, 3 Feb 2020 11:22:46 +0200 From: Andy Shevchenko To: "Calvin Johnson (OSS)" Cc: Dan Carpenter , "linux.cj@gmail.com" , Jon Nettleton , Russell King - ARM Linux , Makarand Pawagi , Cristi Sovaiala , Laurentiu Tudor , Ioana Ciornei , Varun Sethi , Pankaj Bansal , "Rajesh V. Bikkina" , Antoine Tenart , "David S. Miller" , Dmitry Torokhov , Greg Kroah-Hartman , Heikki Krogerus , Matteo Croce , Maxime Chevallier , "Rafael J. Wysocki" , Russell King , Sakari Ailus , Thomas Gleixner , Linux Kernel Mailing List , netdev Subject: Re: [PATCH v1 4/7] device property: fwnode_get_phy_mode: Change API to solve int/unit warnings Message-ID: <20200203092246.GX32742@smile.fi.intel.com> References: <20200131153440.20870-1-calvin.johnson@nxp.com> <20200131153440.20870-5-calvin.johnson@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 03, 2020 at 09:13:42AM +0000, Calvin Johnson (OSS) wrote: > > -----Original Message----- > > From: Andy Shevchenko > > Subject: Re: [PATCH v1 4/7] device property: fwnode_get_phy_mode: > > Change API to solve int/unit warnings > > > > On Fri, Jan 31, 2020 at 5:38 PM Calvin Johnson > > wrote: > > > > > > From: Calvin Johnson > > > > > > API fwnode_get_phy_mode is modified to follow the changes made by > > > Commit 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve > > > int/unit warnings"). > > > > I think it would be good to base your series on Dan's fix patch. > > This patch is based on Dan's fix patch https://www.spinics.net/lists/netdev/msg606487.html . > Commit 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings"). > Can you please give more clarity on what you meant? Please point to me, if there is some > specific patch that you are referring to. Ah, sorry, I meant the "device property: change device_get_phy_mode() to prevent signedess bugs" [1]. It fixes some PHY initialization issues with the existing code (thus, should be backported). [1]: https://lkml.org/lkml/2020/1/31/1 -- With Best Regards, Andy Shevchenko