netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: harinik@xilinx.com
Cc: nicolas.ferre@microchip.com, claudiu.beznea@microchip.com,
	kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, michal.simek@xilinx.com,
	harini.katakam@xilinx.com, harinikatakamlinux@gmail.com
Subject: Re: [PATCH v2 1/2] net: macb: Remove unnecessary alignment check for TSO
Date: Tue, 04 Feb 2020 12:43:59 +0100 (CET)	[thread overview]
Message-ID: <20200204.124359.1467998825171045884.davem@davemloft.net> (raw)
In-Reply-To: <CAFcVECKXp-s-vteTzmqSDCR0ajugiDK_tnBmacea5NA+Fu02Ng@mail.gmail.com>

From: Harini Katakam <harinik@xilinx.com>
Date: Tue, 4 Feb 2020 15:52:55 +0530

>> > will never trigger this IPPROTO_TCP condition after your change.
> 
> Yes, this is dead code now. I'll remove it.
> 
>> >
>> > A lot of things about this patch do not add up.
> 
> Please let me know if you have any further concerns.

Looks good with the above correction and a rework of your commit message
to explain things more clearly.

Thank you.

  reply	other threads:[~2020-02-04 11:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 13:18 [PATCH v2 0/2] TSO bug fixes Harini Katakam
2020-02-03 13:18 ` [PATCH v2 1/2] net: macb: Remove unnecessary alignment check for TSO Harini Katakam
2020-02-04  9:37   ` David Miller
     [not found]     ` <BN7PR02MB5121912B4AE8633C50D6DE98C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
2020-02-04 10:22       ` Harini Katakam
2020-02-04 11:43         ` David Miller [this message]
2020-02-03 13:18 ` [PATCH v2 2/2] net: macb: Limit maximum GEM TX length in TSO Harini Katakam
2020-02-04  9:37   ` David Miller
     [not found]     ` <BN7PR02MB51215810D1240E98E81F6176C9030@BN7PR02MB5121.namprd02.prod.outlook.com>
2020-02-04 10:26       ` Harini Katakam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204.124359.1467998825171045884.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=claudiu.beznea@microchip.com \
    --cc=harini.katakam@xilinx.com \
    --cc=harinik@xilinx.com \
    --cc=harinikatakamlinux@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).