From: Jakub Kicinski <kuba@kernel.org>
To: Cris Forno <cforno12@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
sashal@kernel.org, tlfalcon@linux.ibm.com, davem@davemloft.net,
mkubecek@suse.cz, willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH, net-next, v4, 1/2] ethtool: Factored out similar ethtool link settings for virtual devices to core
Date: Fri, 14 Feb 2020 08:20:28 -0800 [thread overview]
Message-ID: <20200214082028.3d82d957@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <20200213201410.6912-2-cforno12@linux.vnet.ibm.com>
On Thu, 13 Feb 2020 14:14:09 -0600 Cris Forno wrote:
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 95991e43..149f982 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -394,6 +394,8 @@ struct ethtool_ops {
> struct ethtool_coalesce *);
> int (*set_per_queue_coalesce)(struct net_device *, u32,
> struct ethtool_coalesce *);
> + bool (*virtdev_validate_link_ksettings)(const struct
> + ethtool_link_ksettings *);
Could this callback be passed to ethtool_virtdev_set_link_ksettings()
as an argument instead of being in the global structure? Callers need
to pass speed and duplex pointers anyway.
> int (*get_link_ksettings)(struct net_device *,
> struct ethtool_link_ksettings *);
> int (*set_link_ksettings)(struct net_device *,
next prev parent reply other threads:[~2020-02-14 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:14 [PATCH, net-next, v4, 0/2] net/ethtool: Introduce link_ksettings API for virtual network devices Cris Forno
2020-02-13 20:14 ` [PATCH, net-next, v4, 1/2] ethtool: Factored out similar ethtool link settings for virtual devices to core Cris Forno
2020-02-14 16:20 ` Jakub Kicinski [this message]
2020-02-13 20:14 ` [PATCH, net-next, v4, 2/2] net/ethtool: Introduce link_ksettings API for virtual network devices Cris Forno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214082028.3d82d957@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
--to=kuba@kernel.org \
--cc=cforno12@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=mkubecek@suse.cz \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tlfalcon@linux.ibm.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).