From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCF7C2BA83 for ; Fri, 14 Feb 2020 16:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33EAD2467D for ; Fri, 14 Feb 2020 16:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581698492; bh=lhYkUkKhNIN5XzZ3oL3+l7aoO6QBE7b9lZ90yaiKQ40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GFWdyFDysqPQotOJhX/ylk1PwR48j33zv1WNyXNVV52VBhE/t5937LtYcuZBXv3U4 oXyq36CWEZeYQM+dSTtAWhpF9NmnvPDjQePIh2mql79SzXalwsMx+iXK+Q21pZVRSB bC5WWuZMmt4Z0g9+uKn7v9lPac6UfduIH1bOeuqQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393967AbgBNQlY (ORCPT ); Fri, 14 Feb 2020 11:41:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:58310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393222AbgBNQWg (ORCPT ); Fri, 14 Feb 2020 11:22:36 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57AFB24758; Fri, 14 Feb 2020 16:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581697356; bh=lhYkUkKhNIN5XzZ3oL3+l7aoO6QBE7b9lZ90yaiKQ40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t4ZAHzlHmqwiCYcfl074cQv245fi1dNyiY6EOc7LiCJ9ZlOzTH4u5k6cAV0xlVCUB iSxbgAjQJfHxwAupyE5dt5CebmbQZqov5b2M8bAtinLXq5sxz4uXPPyN8Lu8+FRtyf 3Jm/6os2XbOHLANOrx8XX7+YEFnJwchfvQ+1MykY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , kbuild test robot , "kernelci . org bot" , Olof's autobuilder , Stephen Rothwell , Greg Kroah-Hartman , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 058/141] isdn: don't mark kcapi_proc_exit as __exit Date: Fri, 14 Feb 2020 11:19:58 -0500 Message-Id: <20200214162122.19794-58-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200214162122.19794-1-sashal@kernel.org> References: <20200214162122.19794-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann [ Upstream commit b33bdf8020c94438269becc6dace9ed49257c4ba ] As everybody pointed out by now, my patch to clean up CAPI introduced a link time warning, as the two parts of the capi driver are now in one module and the exit function may need to be called in the error path of the init function: >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit() The function kcapi_exit() references a function in an exit section. Often the function kcapi_proc_exit() has valid usage outside the exit section and the fix is to remove the __exit annotation of kcapi_proc_exit. Remove the incorrect __exit annotation. Reported-by: kbuild test robot Reported-by: kernelci.org bot Reported-by: Olof's autobuilder Reported-by: Stephen Rothwell Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20191216194909.1983639-1-arnd@arndb.de Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/isdn/capi/kcapi_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c index 68db3c5a10636..d6ca626219c93 100644 --- a/drivers/isdn/capi/kcapi_proc.c +++ b/drivers/isdn/capi/kcapi_proc.c @@ -309,7 +309,7 @@ kcapi_proc_init(void) proc_create("capi/driver", 0, NULL, &proc_driver_ops); } -void __exit +void kcapi_proc_exit(void) { remove_proc_entry("capi/driver", NULL); -- 2.20.1