From: Andrew Lunn <andrew@lunn.ch>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Paul Cercueil" <paul@crapouillou.net>,
"David S. Miller" <davem@davemloft.net>,
"Petr Štetiar" <ynezz@true.cz>,
"Richard Fontana" <rfontana@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
letux-kernel@openphoenux.org, kernel@pyra-handheld.com
Subject: Re: [PATCH v2] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter
Date: Fri, 14 Feb 2020 17:32:05 +0100 [thread overview]
Message-ID: <20200214163205.GL31084@lunn.ch> (raw)
In-Reply-To: <0d6b4d383bb29ed5d4710e9706e5ad6c7f92d9da.1581696454.git.hns@goldelico.com>
On Fri, Feb 14, 2020 at 05:07:35PM +0100, H. Nikolaus Schaller wrote:
> The MIPS Ingenic CI20 board is shipped with a quite old u-boot
> (ci20-v2013.10 see https://elinux.org/CI20_Dev_Zone). This passes
> the MAC address through dm9000.mac_addr=xx:xx:xx:xx:xx:xx
> kernel module parameter to give the board a fixed MAC address.
I think this will get ACKed.
There is a well defined way to pass the MAC address via DT. The driver
supports that already.
uboot for this board appears to be open:
https://github.com/MIPS/CI20_u-boot
and it is documented to how build it.
So there is no reason why it cannot be made to support the standard
mechanism.
Andrew
next prev parent reply other threads:[~2020-02-14 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 16:07 [PATCH v2] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter H. Nikolaus Schaller
2020-02-14 16:32 ` Andrew Lunn [this message]
2020-02-14 17:51 ` David Miller
2020-02-14 18:47 ` Paul Cercueil
2020-02-14 19:24 ` H. Nikolaus Schaller
2020-02-14 19:38 ` [Letux-kernel] " H. Nikolaus Schaller
2020-02-14 19:57 ` Paul Cercueil
2020-02-14 20:05 ` H. Nikolaus Schaller
2020-02-14 20:17 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214163205.GL31084@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).