Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] dt-bindings: net: mdio: remove compatible string from example
@ 2020-02-14 19:44 Grygorii Strashko
  2020-02-19 20:09 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Grygorii Strashko @ 2020-02-14 19:44 UTC (permalink / raw)
  To: Rob Herring, Simon Horman, Andrew Lunn, Florian Fainelli,
	Mark Rutland, Heiner Kallweit, devicetree
  Cc: David S . Miller, netdev, linux-kernel, Grygorii Strashko

Remove vendor specific compatible string from example, otherwise DT YAML
schemas validation may trigger warnings specific to TI ti,davinci_mdio
and not to the generic MDIO example.

For example, the "bus_freq" is required for davinci_mdio, but not required for
generic mdio example. As result following warning will be produced:
 mdio.example.dt.yaml: mdio@5c030000: 'bus_freq' is a required property

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
Remove compatible string from example instead of changing it.

v1: https://patchwork.ozlabs.org/patch/1201674/

 Documentation/devicetree/bindings/net/mdio.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml
index 5d08d2ffd4eb..50c3397a82bc 100644
--- a/Documentation/devicetree/bindings/net/mdio.yaml
+++ b/Documentation/devicetree/bindings/net/mdio.yaml
@@ -56,7 +56,6 @@ patternProperties:
 examples:
   - |
     davinci_mdio: mdio@5c030000 {
-        compatible = "ti,davinci_mdio";
         reg = <0x5c030000 0x1000>;
         #address-cells = <1>;
         #size-cells = <0>;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] dt-bindings: net: mdio: remove compatible string from example
  2020-02-14 19:44 [PATCH v2] dt-bindings: net: mdio: remove compatible string from example Grygorii Strashko
@ 2020-02-19 20:09 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-02-19 20:09 UTC (permalink / raw)
  To: Grygorii Strashko
  Cc: Simon Horman, Andrew Lunn, Florian Fainelli, Mark Rutland,
	Heiner Kallweit, devicetree, David S . Miller, netdev,
	linux-kernel, Grygorii Strashko

On Fri, 14 Feb 2020 21:44:08 +0200, Grygorii Strashko wrote:
> Remove vendor specific compatible string from example, otherwise DT YAML
> schemas validation may trigger warnings specific to TI ti,davinci_mdio
> and not to the generic MDIO example.
> 
> For example, the "bus_freq" is required for davinci_mdio, but not required for
> generic mdio example. As result following warning will be produced:
>  mdio.example.dt.yaml: mdio@5c030000: 'bus_freq' is a required property
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Remove compatible string from example instead of changing it.
> 
> v1: https://patchwork.ozlabs.org/patch/1201674/
> 
>  Documentation/devicetree/bindings/net/mdio.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 19:44 [PATCH v2] dt-bindings: net: mdio: remove compatible string from example Grygorii Strashko
2020-02-19 20:09 ` Rob Herring

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git