netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: boqun.feng@gmail.com, Jules Irenge <jbi.octave@gmail.com>,
	Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
	Edward Cree <ecree@solarflare.com>,
	Martin Habets <mhabets@solarflare.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org (open list:SFC NETWORK DRIVER)
Subject: [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf()
Date: Fri, 14 Feb 2020 20:47:32 +0000	[thread overview]
Message-ID: <20200214204741.94112-22-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com>

Sparse reports a warning at  efx_ef10_try_update_nic_stats_vf()

warning: context imbalance in  efx_ef10_try_update_nic_stats_vf()
	 - unexpected unlock

The root cause is the missing annotation at
efx_ef10_try_update_nic_stats_vf()
Add the missing __must_hold(&efx->stats_lock) annotattion

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/net/ethernet/sfc/ef10.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index 52113b7529d6..b1102c7e814d 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -1820,6 +1820,7 @@ static size_t efx_ef10_update_stats_pf(struct efx_nic *efx, u64 *full_stats,
 }
 
 static int efx_ef10_try_update_nic_stats_vf(struct efx_nic *efx)
+	__must_hold(&efx->stats_lock)
 {
 	MCDI_DECLARE_BUF(inbuf, MC_CMD_MAC_STATS_IN_LEN);
 	struct efx_ef10_nic_data *nic_data = efx->nic_data;
-- 
2.24.1


  parent reply	other threads:[~2020-02-14 20:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0/30>
     [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com>
2020-02-14 20:47   ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge
2020-02-14 20:47   ` Jules Irenge [this message]
2020-02-17 18:00     ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Martin Habets
2020-02-14 20:47   ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge
2020-02-14 20:47   ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge
2020-02-14 20:47   ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge
2020-02-14 20:47   ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge
2020-02-14 20:47   ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge
2020-02-14 20:47   ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge
2020-02-14 20:47   ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge
     [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
2020-02-23 23:16   ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-23 23:16   ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-23 23:16   ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-23 23:16   ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-23 23:16   ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge
2020-02-24 21:29     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214204741.94112-22-jbi.octave@gmail.com \
    --to=jbi.octave@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=davem@davemloft.net \
    --cc=ecree@solarflare.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=mhabets@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).