* [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> @ 2020-02-14 20:47 ` Jules Irenge 2020-02-14 20:47 ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge ` (7 subsequent siblings) 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, Don Fry, David S. Miller, open list:PCNET32 NETWORK DRIVER Sparse reports a warning at pcnet32_suspend() warning: context imbalance in pcnet32_suspend() - unexpected unlock The root cause is the missing annotation at pcnet32_suspend() Add the missing __must_hold(&lp->lock) annotattion Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- drivers/net/ethernet/amd/pcnet32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index dc7d88227e76..ac6c19441932 100644 --- a/drivers/net/ethernet/amd/pcnet32.c +++ b/drivers/net/ethernet/amd/pcnet32.c @@ -684,7 +684,7 @@ static void pcnet32_poll_controller(struct net_device *dev) * lp->lock must be held. */ static int pcnet32_suspend(struct net_device *dev, unsigned long *flags, - int can_sleep) + int can_sleep) __must_hold(&lp->lock) { int csr5; struct pcnet32_private *lp = netdev_priv(dev); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> 2020-02-14 20:47 ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 2020-02-17 18:00 ` Martin Habets 2020-02-14 20:47 ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge ` (6 subsequent siblings) 8 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, Solarflare linux maintainers, Edward Cree, Martin Habets, David S. Miller, open list:SFC NETWORK DRIVER Sparse reports a warning at efx_ef10_try_update_nic_stats_vf() warning: context imbalance in efx_ef10_try_update_nic_stats_vf() - unexpected unlock The root cause is the missing annotation at efx_ef10_try_update_nic_stats_vf() Add the missing __must_hold(&efx->stats_lock) annotattion Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- drivers/net/ethernet/sfc/ef10.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 52113b7529d6..b1102c7e814d 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -1820,6 +1820,7 @@ static size_t efx_ef10_update_stats_pf(struct efx_nic *efx, u64 *full_stats, } static int efx_ef10_try_update_nic_stats_vf(struct efx_nic *efx) + __must_hold(&efx->stats_lock) { MCDI_DECLARE_BUF(inbuf, MC_CMD_MAC_STATS_IN_LEN); struct efx_ef10_nic_data *nic_data = efx->nic_data; -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() 2020-02-14 20:47 ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge @ 2020-02-17 18:00 ` Martin Habets 0 siblings, 0 replies; 34+ messages in thread From: Martin Habets @ 2020-02-17 18:00 UTC (permalink / raw) To: Jules Irenge, linux-kernel Cc: boqun.feng, Solarflare linux maintainers, Edward Cree, David S. Miller, open list:SFC NETWORK DRIVER On 14/02/2020 20:47, Jules Irenge wrote: > Sparse reports a warning at efx_ef10_try_update_nic_stats_vf() > > warning: context imbalance in efx_ef10_try_update_nic_stats_vf() > - unexpected unlock > > The root cause is the missing annotation at > efx_ef10_try_update_nic_stats_vf() > Add the missing __must_hold(&efx->stats_lock) annotattion > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Thanks Acked-by: Martin Habets <mhabets@solarflare.com> > --- > drivers/net/ethernet/sfc/ef10.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c > index 52113b7529d6..b1102c7e814d 100644 > --- a/drivers/net/ethernet/sfc/ef10.c > +++ b/drivers/net/ethernet/sfc/ef10.c > @@ -1820,6 +1820,7 @@ static size_t efx_ef10_update_stats_pf(struct efx_nic *efx, u64 *full_stats, > } > > static int efx_ef10_try_update_nic_stats_vf(struct efx_nic *efx) > + __must_hold(&efx->stats_lock) > { > MCDI_DECLARE_BUF(inbuf, MC_CMD_MAC_STATS_IN_LEN); > struct efx_ef10_nic_data *nic_data = efx->nic_data; > ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> 2020-02-14 20:47 ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge 2020-02-14 20:47 ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 2020-02-14 20:47 ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge ` (5 subsequent siblings) 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller, Jakub Kicinski, open list:TIPC NETWORK LAYER, open list:TIPC NETWORK LAYER Sparse reports a warning at tipc_node_read_lock() warning: context imbalance in tipc_node_read_lock - wrong count at exit The root cause is the missing annotation at tipc_node_read_lock() Add the missing __acquires(&n->lock) annotattion Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index 99b28b69fc17..4e267ed94a2a 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -351,7 +351,7 @@ static struct tipc_node *tipc_node_find_by_id(struct net *net, u8 *id) return found ? n : NULL; } -static void tipc_node_read_lock(struct tipc_node *n) +static void tipc_node_read_lock(struct tipc_node *n) __acquires(&n->lock) { read_lock_bh(&n->lock); } -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> ` (2 preceding siblings ...) 2020-02-14 20:47 ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 2020-02-14 20:47 ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge ` (4 subsequent siblings) 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller, Jakub Kicinski, open list:TIPC NETWORK LAYER, open list:TIPC NETWORK LAYER Sparse reports a warning at tipc_node_read_unlock() warning: context imbalance in tipc_node_read_unlock - unexpected unlock The root cause is the missing annotation at tipc_node_read_unlock() Add the missing __releases(&n->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index 4e267ed94a2a..eafa38896e3a 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -356,7 +356,7 @@ static void tipc_node_read_lock(struct tipc_node *n) __acquires(&n->lock) read_lock_bh(&n->lock); } -static void tipc_node_read_unlock(struct tipc_node *n) +static void tipc_node_read_unlock(struct tipc_node *n) __releases(&n->lock) { read_unlock_bh(&n->lock); } -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> ` (3 preceding siblings ...) 2020-02-14 20:47 ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 2020-02-14 20:47 ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge ` (3 subsequent siblings) 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller, Jakub Kicinski, open list:TIPC NETWORK LAYER, open list:TIPC NETWORK LAYER Sparse reports a warning at tipc_node_write_lock() warning: context imbalance in tipc_node_write_lock - wrong count at exit The root cause is the missing annotation at tipc_node_write_lock() Add the missing __acquires(&n->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index eafa38896e3a..d8401789fa23 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -361,7 +361,7 @@ static void tipc_node_read_unlock(struct tipc_node *n) __releases(&n->lock) read_unlock_bh(&n->lock); } -static void tipc_node_write_lock(struct tipc_node *n) +static void tipc_node_write_lock(struct tipc_node *n) __acquires(&n->lock) { write_lock_bh(&n->lock); } -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> ` (4 preceding siblings ...) 2020-02-14 20:47 ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 2020-02-14 20:47 ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge ` (2 subsequent siblings) 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller, Jakub Kicinski, open list:TIPC NETWORK LAYER, open list:TIPC NETWORK LAYER Sparse reports a warning at tipc_node_write_unlock_fast() warning: context imbalance in tipc_node_write_unlock_fast - unexpected unlock The root cause is the missing annotation at tipc_node_write_unlock_fast() Add the missing __releases(&n->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/tipc/node.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tipc/node.c b/net/tipc/node.c index d8401789fa23..cc656b2205db 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -367,6 +367,7 @@ static void tipc_node_write_lock(struct tipc_node *n) __acquires(&n->lock) } static void tipc_node_write_unlock_fast(struct tipc_node *n) + __releases(&n->lock) { write_unlock_bh(&n->lock); } -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> ` (5 preceding siblings ...) 2020-02-14 20:47 ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 2020-02-14 20:47 ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge 2020-02-14 20:47 ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller, Jakub Kicinski, open list:TIPC NETWORK LAYER, open list:TIPC NETWORK LAYER Sparse reports a warning at tipc_node_write_unlock() warning: context imbalance in tipc_node_write_unlock - unexpected unlock The root cause is the missing annotation at tipc_node_write_unlock() Add the missing __releases(&n->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index cc656b2205db..c3b810427d24 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -372,7 +372,7 @@ static void tipc_node_write_unlock_fast(struct tipc_node *n) write_unlock_bh(&n->lock); } -static void tipc_node_write_unlock(struct tipc_node *n) +static void tipc_node_write_unlock(struct tipc_node *n) __releases(&n->lock) { struct net *net = n->net; u32 addr = 0; -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 29/30] net: Add missing annotation for netlink_walk_start() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> ` (6 preceding siblings ...) 2020-02-14 20:47 ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 2020-02-14 20:47 ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, David S. Miller, Jakub Kicinski, Patrick Talbert, Herbert Xu, Greg Kroah-Hartman, Taehee Yoo, Tetsuo Handa, Li RongQing, Thomas Gleixner, open list:NETWORKING [GENERAL] Sparse reports a warning at netlink_walk_start() warning: context imbalance in netlink_walk_start() - wrong count at exit The root cause is the missing annotation at netlink_walk_start() A close look at rhashtable_walk_start_check() shows that an __acquires(RCU) is needed here. Add the missing __acquires(RCU) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 4e31721e7293..a3fddc845538 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2539,7 +2539,7 @@ struct nl_seq_iter { int link; }; -static void netlink_walk_start(struct nl_seq_iter *iter) +static void netlink_walk_start(struct nl_seq_iter *iter) __acquires(RCU) { rhashtable_walk_enter(&nl_table[iter->link].hash, &iter->hti); rhashtable_walk_start(&iter->hti); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> ` (7 preceding siblings ...) 2020-02-14 20:47 ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge @ 2020-02-14 20:47 ` Jules Irenge 8 siblings, 0 replies; 34+ messages in thread From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, Jules Irenge, David S. Miller, Jakub Kicinski, Taehee Yoo, Johannes Berg, Tetsuo Handa, Thomas Gleixner, Patrick Talbert, Herbert Xu, Li RongQing, open list:NETWORKING [GENERAL] Sparse reports a warning at netlink_walk_stop() warning: context imbalance in netlink_walk_stop() - unexpected unlock The root cause is the missing annotation at netlink_walk_stop() A close look at rhashtable_walk_stop() shows that an __releases(RCU) is needed here Add the missing __releases(RCU) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index a3fddc845538..7a287dc73f63 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2545,7 +2545,7 @@ static void netlink_walk_start(struct nl_seq_iter *iter) __acquires(RCU) rhashtable_walk_start(&iter->hti); } -static void netlink_walk_stop(struct nl_seq_iter *iter) +static void netlink_walk_stop(struct nl_seq_iter *iter) __releases(RCU) { rhashtable_walk_stop(&iter->hti); rhashtable_walk_exit(&iter->hti); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
[parent not found: <20200223231711.157699-1-jbi.octave@gmail.com>]
* [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge ` (10 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman, Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski, open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL] Sparse reports a warning at sctp_err_finish() warning: context imbalance in sctp_err_finish() - unexpected unlock The root cause is a missing annotation at sctp_err_finish() Add the missing __releases(&((__sk)->sk_lock.slock)) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/sctp/input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/input.c b/net/sctp/input.c index efaaefc3bb1c..55d4fc6f371d 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -548,6 +548,7 @@ struct sock *sctp_err_lookup(struct net *net, int family, struct sk_buff *skb, /* Common cleanup code for icmp/icmpv6 error handler. */ void sctp_err_finish(struct sock *sk, struct sctp_transport *t) + __releases(&((__sk)->sk_lock.slock)) { bh_unlock_sock(sk); sctp_transport_put(t); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() 2020-02-23 23:16 ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge @ 2020-02-24 21:28 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw) To: jbi.octave Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner, kuba, linux-sctp, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:45 +0000 > Sparse reports a warning at sctp_err_finish() > warning: context imbalance in sctp_err_finish() - unexpected unlock > > The root cause is a missing annotation at sctp_err_finish() > Add the missing __releases(&((__sk)->sk_lock.slock)) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> 2020-02-23 23:16 ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge ` (9 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman, Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski, open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL] Sparse reports a warning at sctp_transport_walk_start() warning: context imbalance in sctp_transport_walk_start - wrong count at exit The root cause is the missing annotation at sctp_transport_walk_start() Add the missing __acquires(RCU) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 1b56fc440606..05be67bb0474 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -5333,7 +5333,7 @@ int sctp_get_sctp_info(struct sock *sk, struct sctp_association *asoc, EXPORT_SYMBOL_GPL(sctp_get_sctp_info); /* use callback to avoid exporting the core structure */ -void sctp_transport_walk_start(struct rhashtable_iter *iter) +void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU) { rhltable_walk_enter(&sctp_transport_hashtable, iter); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() 2020-02-23 23:16 ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge @ 2020-02-24 21:28 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw) To: jbi.octave Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner, kuba, linux-sctp, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:46 +0000 > Sparse reports a warning at sctp_transport_walk_start() > > warning: context imbalance in sctp_transport_walk_start > - wrong count at exit > > The root cause is the missing annotation at sctp_transport_walk_start() > Add the missing __acquires(RCU) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> 2020-02-23 23:16 ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge 2020-02-23 23:16 ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge ` (8 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman, Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski, open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL] Sparse reports a warning at sctp_transport_walk_stop() warning: context imbalance in sctp_transport_walk_stop - wrong count at exit The root cause is the missing annotation at sctp_transport_walk_stop() Add the missing __releases(RCU) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 05be67bb0474..fed26a1e9518 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -5340,7 +5340,7 @@ void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU) rhashtable_walk_start(iter); } -void sctp_transport_walk_stop(struct rhashtable_iter *iter) +void sctp_transport_walk_stop(struct rhashtable_iter *iter) __releases(RCU) { rhashtable_walk_stop(iter); rhashtable_walk_exit(iter); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() 2020-02-23 23:16 ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge @ 2020-02-24 21:28 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw) To: jbi.octave Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner, kuba, linux-sctp, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:47 +0000 > Sparse reports a warning at sctp_transport_walk_stop() > > warning: context imbalance in sctp_transport_walk_stop > - wrong count at exit > > The root cause is the missing annotation at sctp_transport_walk_stop() > Add the missing __releases(RCU) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 07/30] net: Add missing annotation for llc_seq_start() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (2 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge ` (7 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, David S. Miller, Jakub Kicinski, open list:LLC (802.2) Sparse reports a warning at llc_seq_start() warning: context imbalance in llc_seq_start() - wrong count at exit The root cause is the msiing annotation at llc_seq_start() Add the missing __acquires(RCU) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/llc/llc_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/llc/llc_proc.c b/net/llc/llc_proc.c index f3a36c16a5e7..a4eccb98220a 100644 --- a/net/llc/llc_proc.c +++ b/net/llc/llc_proc.c @@ -56,7 +56,7 @@ static struct sock *llc_get_sk_idx(loff_t pos) return sk; } -static void *llc_seq_start(struct seq_file *seq, loff_t *pos) +static void *llc_seq_start(struct seq_file *seq, loff_t *pos) __acquires(RCU) { loff_t l = *pos; -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 07/30] net: Add missing annotation for llc_seq_start() 2020-02-23 23:16 ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge @ 2020-02-24 21:28 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, kuba, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:48 +0000 > Sparse reports a warning at llc_seq_start() > > warning: context imbalance in llc_seq_start() - wrong count at exit > The root cause is the msiing annotation at llc_seq_start() > > Add the missing __acquires(RCU) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 08/30] netrom: Add missing annotation for nr_info_start() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (3 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge ` (6 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller, Jakub Kicinski, open list:NETROM NETWORK LAYER, open list:NETWORKING [GENERAL] Sparse reports a warning at nr_info_start() warning: context imbalance in nr_info_start() - wrong count at exit The root cause is the missing annotation at nr_info_start() Add the missing __acquires(&nr_list_lock) Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netrom/af_netrom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c index 58d5373c513c..8be06e61ff03 100644 --- a/net/netrom/af_netrom.c +++ b/net/netrom/af_netrom.c @@ -1230,6 +1230,7 @@ static int nr_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) #ifdef CONFIG_PROC_FS static void *nr_info_start(struct seq_file *seq, loff_t *pos) + __acquires(&nr_list_lock) { spin_lock_bh(&nr_list_lock); return seq_hlist_start_head(&nr_list, *pos); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 08/30] netrom: Add missing annotation for nr_info_start() 2020-02-23 23:16 ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:49 +0000 > Sparse reports a warning at nr_info_start() > warning: context imbalance in nr_info_start() - wrong count at exit > The root cause is the missing annotation at nr_info_start() > Add the missing __acquires(&nr_list_lock) > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (4 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge ` (5 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller, Jakub Kicinski, open list:NETROM NETWORK LAYER, open list:NETWORKING [GENERAL] Sparse reports a warning at nr_info_stop() warning: context imbalance in nr_info_stop() - unexpected unlock The root cause is the missing annotation at nr_info_stop() Add the missing __releases(&nr_list_lock) Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netrom/af_netrom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c index 8be06e61ff03..7b1a74f74aad 100644 --- a/net/netrom/af_netrom.c +++ b/net/netrom/af_netrom.c @@ -1242,6 +1242,7 @@ static void *nr_info_next(struct seq_file *seq, void *v, loff_t *pos) } static void nr_info_stop(struct seq_file *seq, void *v) + __releases(&nr_list_lock) { spin_unlock_bh(&nr_list_lock); } -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() 2020-02-23 23:16 ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:50 +0000 > Sparse reports a warning at nr_info_stop() > warning: context imbalance in nr_info_stop() - unexpected unlock > The root cause is the missing annotation at nr_info_stop() > Add the missing __releases(&nr_list_lock) > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (5 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge ` (4 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller, Jakub Kicinski, open list:NETROM NETWORK LAYER, open list:NETWORKING [GENERAL] Sparse reports a warning at nr_node_start() warning: context imbalance in nr_node_start() - wrong count at exit The root cause is the missing annotation at nr_node_start() Add the missing __acquires(&nr_node_list_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index d41335bad1f8..fe278fc24153 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -838,6 +838,7 @@ int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25) #ifdef CONFIG_PROC_FS static void *nr_node_start(struct seq_file *seq, loff_t *pos) + __acquires(&nr_node_list_lock) { spin_lock_bh(&nr_node_list_lock); return seq_hlist_start_head(&nr_node_list, *pos); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() 2020-02-23 23:16 ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:51 +0000 > Sparse reports a warning at nr_node_start() > warning: context imbalance in nr_node_start() - wrong count at exit > The root cause is the missing annotation at nr_node_start() > Add the missing __acquires(&nr_node_list_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (6 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge ` (3 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller, Jakub Kicinski, open list:NETROM NETWORK LAYER, open list:NETWORKING [GENERAL] Sparse reports a warning at nr_node_stop() warning: context imbalance in nr_node_stop() - wrong count at exit The root cause is the missing annotation at nr_node_stop() Add the missing __releases(&nr_node_list_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index fe278fc24153..637a743c060d 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -850,6 +850,7 @@ static void *nr_node_next(struct seq_file *seq, void *v, loff_t *pos) } static void nr_node_stop(struct seq_file *seq, void *v) + __releases(&nr_node_list_lock) { spin_unlock_bh(&nr_node_list_lock); } -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() 2020-02-23 23:16 ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:52 +0000 > Sparse reports a warning at nr_node_stop() > warning: context imbalance in nr_node_stop() - wrong count at exit > The root cause is the missing annotation at nr_node_stop() > Add the missing __releases(&nr_node_list_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (7 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge ` (2 subsequent siblings) 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller, Jakub Kicinski, open list:NETROM NETWORK LAYER, open list:NETWORKING [GENERAL] Sparse reports a warning at nr_neigh_start() warning: context imbalance in nr_neigh_start() - wrong count at exit The root cause is the missing annotation at nr_neigh_start() Add the missing __acquires(&nr_neigh_list_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index 637a743c060d..33e7b91fc805 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -895,6 +895,7 @@ const struct seq_operations nr_node_seqops = { }; static void *nr_neigh_start(struct seq_file *seq, loff_t *pos) + __acquires(&nr_neigh_list_lock) { spin_lock_bh(&nr_neigh_list_lock); return seq_hlist_start_head(&nr_neigh_list, *pos); -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() 2020-02-23 23:16 ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:53 +0000 > Sparse reports a warning at nr_neigh_start() > warning: context imbalance in nr_neigh_start() - wrong count at exit > The root cause is the missing annotation at nr_neigh_start() > Add the missing __acquires(&nr_neigh_list_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (8 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge 2020-02-23 23:16 ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller, Jakub Kicinski, open list:NETROM NETWORK LAYER, open list:NETWORKING [GENERAL] Sparse reports a warning at nr_neigh_stop() warning: context imbalance in nr_neigh_stop() - unexpected unlock The root cause is the missing annotation at nr_neigh_stop() Add the missing __releases(&nr_neigh_list_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index 33e7b91fc805..79f12d8c7b86 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -907,6 +907,7 @@ static void *nr_neigh_next(struct seq_file *seq, void *v, loff_t *pos) } static void nr_neigh_stop(struct seq_file *seq, void *v) + __releases(&nr_neigh_list_lock) { spin_unlock_bh(&nr_neigh_list_lock); } -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() 2020-02-23 23:16 ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:54 +0000 > Sparse reports a warning at nr_neigh_stop() > warning: context imbalance in nr_neigh_stop() - unexpected unlock > The root cause is the missing annotation at nr_neigh_stop() > Add the missing __releases(&nr_neigh_list_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (9 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, Gerrit Renker, David S. Miller, Jakub Kicinski, open list:DCCP PROTOCOL, open list:NETWORKING [GENERAL] Sparse reports a warning at dccp_child_process() warning: context imbalance in dccp_child_process() - unexpected unlock The root cause is the missing annotation at dccp_child_process() Add the missing __releases(child) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/dccp/minisocks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c index 25187528c308..c5c74a34d139 100644 --- a/net/dccp/minisocks.c +++ b/net/dccp/minisocks.c @@ -216,6 +216,7 @@ EXPORT_SYMBOL_GPL(dccp_check_req); */ int dccp_child_process(struct sock *parent, struct sock *child, struct sk_buff *skb) + __releases(child) { int ret = 0; const int state = child->sk_state; -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() 2020-02-23 23:16 ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave; +Cc: boqun.feng, linux-kernel, gerrit, kuba, dccp, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:55 +0000 > Sparse reports a warning at dccp_child_process() > warning: context imbalance in dccp_child_process() - unexpected unlock > The root cause is the missing annotation at dccp_child_process() > Add the missing __releases(child) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> ` (10 preceding siblings ...) 2020-02-23 23:16 ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge @ 2020-02-23 23:16 ` Jules Irenge 2020-02-24 21:29 ` David Miller 11 siblings, 1 reply; 34+ messages in thread From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw) To: boqun.feng Cc: jbi.octave, linux-kernel, David S. Miller, Jakub Kicinski, Allison Randal, Steffen Klassert, Jens Axboe, Hannes Reinecke, Kirill Tkhai, Eric Dumazet, Thomas Gleixner, Pankaj Bharadiya, Arnd Bergmann, Qian Cai, open list:NETWORKING [GENERAL] Sparse reports a warning unix_wait_for_peer() warning: context imbalance in unix_wait_for_peer() - unexpected unlock The root cause is the missing annotation at unix_wait_for_peer() Add the missing annotation __releases(&unix_sk(other)->lock) Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 62c12cb5763e..cbd7dc01e147 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -1207,6 +1207,7 @@ static int unix_dgram_connect(struct socket *sock, struct sockaddr *addr, } static long unix_wait_for_peer(struct sock *other, long timeo) + __releases(&unix_sk(other)->lock) { struct unix_sock *u = unix_sk(other); int sched; -- 2.24.1 ^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() 2020-02-23 23:16 ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge @ 2020-02-24 21:29 ` David Miller 0 siblings, 0 replies; 34+ messages in thread From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw) To: jbi.octave Cc: boqun.feng, linux-kernel, kuba, allison, steffen.klassert, axboe, hare, ktkhai, edumazet, tglx, pankaj.laxminarayan.bharadiya, arnd, cai, netdev From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:56 +0000 > Sparse reports a warning unix_wait_for_peer() > > warning: context imbalance in unix_wait_for_peer() - unexpected unlock > > The root cause is the missing annotation at unix_wait_for_peer() > Add the missing annotation __releases(&unix_sk(other)->lock) > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied. ^ permalink raw reply [flat|nested] 34+ messages in thread
end of thread, other threads:[~2020-02-24 21:30 UTC | newest] Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <0/30> [not found] ` <20200214204741.94112-1-jbi.octave@gmail.com> 2020-02-14 20:47 ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge 2020-02-14 20:47 ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge 2020-02-17 18:00 ` Martin Habets 2020-02-14 20:47 ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge 2020-02-14 20:47 ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge 2020-02-14 20:47 ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge 2020-02-14 20:47 ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge 2020-02-14 20:47 ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge 2020-02-14 20:47 ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge 2020-02-14 20:47 ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge [not found] ` <20200223231711.157699-1-jbi.octave@gmail.com> 2020-02-23 23:16 ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge 2020-02-24 21:28 ` David Miller 2020-02-23 23:16 ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge 2020-02-24 21:29 ` David Miller 2020-02-23 23:16 ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge 2020-02-24 21:29 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).