Netdev Archive on
 help / color / Atom feed
* [PATCH net v2 0/3] bonding: fix bonding interface bugs
@ 2020-02-15 10:49 Taehee Yoo
  2020-02-17  3:32 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Taehee Yoo @ 2020-02-15 10:49 UTC (permalink / raw)
  To: davem, kuba, j.vosburgh, vfalico, andy, eric.dumazet, netdev; +Cc: ap420073

This patchset fixes lockdep problem in bonding interface

1. The first patch is to add missing netdev_update_lockdep_key().
After bond_release(), netdev_update_lockdep_key() should be called.
But both ioctl path and attribute path don't call
This patch adds missing netdev_update_lockdep_key().

2. The second patch is to export netdev_next_lower_dev_rcu symbol.
netdev_next_lower_dev_rcu() is useful to implement the function,
which is to walk their all lower interfaces.
This patch is actually a preparing patch for the third patch.

3. The last patch is to fix lockdep waring in bond_get_stats().
The stats_lock uses a dynamic lockdep key.
So, after "nomaster" operation, updating the dynamic lockdep key
routine is needed. but it doesn't
So, lockdep warning occurs.

Change log:
v1 -> v2:
 - Update headline from "fix bonding interface bugs"
   to "bonding: fix bonding interface bugs"
 - Drop a patch("bonding: do not collect slave's stats")
 - Add new patches
   - ("net: export netdev_next_lower_dev_rcu()")
   - ("bonding: fix lockdep warning in bond_get_stats()")

Taehee Yoo (3):
  bonding: add missing netdev_update_lockdep_key()
  net: export netdev_next_lower_dev_rcu()
  bonding: fix lockdep warning in bond_get_stats()

 drivers/net/bonding/bond_main.c    | 55 ++++++++++++++++++++++++++++--
 drivers/net/bonding/bond_options.c |  2 ++
 include/linux/netdevice.h          |  7 ++--
 net/core/dev.c                     |  6 ++--
 4 files changed, 60 insertions(+), 10 deletions(-)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-15 10:49 [PATCH net v2 0/3] bonding: fix bonding interface bugs Taehee Yoo
2020-02-17  3:32 ` David Miller

Netdev Archive on

Archives are clonable:
	git clone --mirror netdev/git/0.git
	git clone --mirror netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ \
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone