From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzkaller@googlegroups.com, jiri@mellanox.com
Subject: Re: [PATCH net] net: add strict checks in netdev_name_node_alt_destroy()
Date: Sun, 16 Feb 2020 19:05:18 -0800 (PST) [thread overview]
Message-ID: <20200216.190518.584096983278979522.davem@davemloft.net> (raw)
In-Reply-To: <20200214155353.71062-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 14 Feb 2020 07:53:53 -0800
> netdev_name_node_alt_destroy() does a lookup over all
> device names of a namespace.
>
> We need to make sure the name belongs to the device
> of interest, and that we do not destroy its primary
> name, since we rely on it being not deleted :
> dev->name_node would indeed point to freed memory.
>
> syzbot report was the following :
...
> Fixes: 36fbf1e52bd3 ("net: rtnetlink: add linkprop commands to add and delete alternative ifnames")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2020-02-17 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 15:53 [PATCH net] net: add strict checks in netdev_name_node_alt_destroy() Eric Dumazet
2020-02-14 20:40 ` Jiri Pirko
2020-02-17 3:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216.190518.584096983278979522.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).