From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BDFC35646 for ; Fri, 21 Feb 2020 18:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A1AB222C4 for ; Fri, 21 Feb 2020 18:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729534AbgBUSE1 (ORCPT ); Fri, 21 Feb 2020 13:04:27 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:65499 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728759AbgBUSE1 (ORCPT ); Fri, 21 Feb 2020 13:04:27 -0500 X-Originating-IP: 92.184.108.100 Received: from localhost (unknown [92.184.108.100]) (Authenticated sender: antoine.tenart@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id BA3EA40004; Fri, 21 Feb 2020 18:04:24 +0000 (UTC) Date: Fri, 21 Feb 2020 19:04:23 +0100 From: Antoine Tenart To: Igor Russkikh Cc: netdev@vger.kernel.org, "David S . Miller" , Antoine Tenart , Mark Starovoytov , Dmitry Bogdanov Subject: Re: [RFC 10/18] net: macsec: enable HW offloading by default (when available) Message-ID: <20200221180423.GE3530@kwain> References: <20200214150258.390-1-irusskikh@marvell.com> <20200214150258.390-11-irusskikh@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200214150258.390-11-irusskikh@marvell.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, On Fri, Feb 14, 2020 at 06:02:50PM +0300, Igor Russkikh wrote: > From: Mark Starovoytov > > This patch makes HW offload to be enabled by default (when available). > This patch along with the next one (reporting real_dev features) are > both required to fix the issue described below. > > Issue description: > real_dev features are disabled upon macsec creation. > > Root cause: > Features limitation (specific to SW MACSec limitation) is being applied > to HW offloaded case as well. > This causes 'set_features' request on the real_dev with reduced feature > set due to chain propagation. > IF SW MACSec limitations are not applied to HW offloading case (see the > next path), then we still face an issue, because SW MACSec is enabled by > default. > > Proposed solution: > Enable HW offloading by default (when available). I would say enabling offloading by default is a no-go, and was discussed when MACsec offloading was initially proposed. But as you said in the cover letter, a good way to do this would be to allow setting the offloading mode when the MACsec interface is created (-> an option in iproute2). Thanks, Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com