From: Jiri Pirko <jiri@resnulli.us>
To: madhuparnabhowmik10@gmail.com
Cc: jiri@mellanox.com, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joel@joelfernandes.org,
frextrite@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
paulmck@kernel.org
Subject: Re: [PATCH] net: core: devlink.c: Hold devlink->lock from the beginning of devlink_dpipe_table_register()
Date: Sat, 22 Feb 2020 07:26:40 +0100 [thread overview]
Message-ID: <20200222062640.GA2228@nanopsycho> (raw)
In-Reply-To: <20200221180943.17415-1-madhuparnabhowmik10@gmail.com>
Fri, Feb 21, 2020 at 07:09:43PM CET, madhuparnabhowmik10@gmail.com wrote:
>From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
>devlink_dpipe_table_find() should be called under either
>rcu_read_lock() or devlink->lock. devlink_dpipe_table_register()
>calls devlink_dpipe_table_find() without holding the lock
>and acquires it later. Therefore hold the devlink->lock
>from the beginning of devlink_dpipe_table_register().
>
>Suggested-by: Jiri Pirko <jiri@mellanox.com>
>Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>---
> net/core/devlink.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/net/core/devlink.c b/net/core/devlink.c
>index 3e8c94155d93..d54e1f156b6f 100644
>--- a/net/core/devlink.c
>+++ b/net/core/devlink.c
>@@ -6840,6 +6840,8 @@ int devlink_dpipe_table_register(struct devlink *devlink,
> {
> struct devlink_dpipe_table *table;
>
>+ mutex_lock(&devlink->lock);
>+
> if (devlink_dpipe_table_find(&devlink->dpipe_table_list, table_name))
> return -EEXIST;
You have to handle the error path.
>
>@@ -6855,7 +6857,6 @@ int devlink_dpipe_table_register(struct devlink *devlink,
> table->priv = priv;
> table->counter_control_extern = counter_control_extern;
>
>- mutex_lock(&devlink->lock);
> list_add_tail_rcu(&table->list, &devlink->dpipe_table_list);
> mutex_unlock(&devlink->lock);
> return 0;
>--
>2.17.1
>
next prev parent reply other threads:[~2020-02-22 6:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 18:09 [PATCH] net: core: devlink.c: Hold devlink->lock from the beginning of devlink_dpipe_table_register() madhuparnabhowmik10
2020-02-22 6:26 ` Jiri Pirko [this message]
2020-02-22 6:55 ` Madhuparna Bhowmik
2020-02-22 6:52 madhuparnabhowmik10
2020-02-23 6:43 ` Jiri Pirko
2020-02-23 10:56 ` Madhuparna Bhowmik
2020-02-23 10:52 madhuparnabhowmik10
2020-02-23 11:01 ` Jiri Pirko
2020-02-23 11:22 madhuparnabhowmik10
2020-02-23 18:17 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222062640.GA2228@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=jiri@mellanox.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).