From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9D1C35670 for ; Sun, 23 Feb 2020 23:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6F5D20880 for ; Sun, 23 Feb 2020 23:19:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="scWgaIOm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbgBWXTf (ORCPT ); Sun, 23 Feb 2020 18:19:35 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:39016 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727329AbgBWXSH (ORCPT ); Sun, 23 Feb 2020 18:18:07 -0500 Received: by mail-wm1-f67.google.com with SMTP id c84so7453448wme.4; Sun, 23 Feb 2020 15:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mf++eeayLsVrcTVe6kbYrrnwfp2AEx+dRuICz5iDthY=; b=scWgaIOmdbwqRz8XkqHo3LJ08oQDqJ3XycbTlHUlm8XzHxJhpKqJfSdF0FCZSu+wt+ EJQQ9eT8yxLTRUnQ82BPqcNqNkxMEAa3G67UWTrXc/6+ahq0CKSGNtKwuFHuZWUn9auX azqIYlkeRinAvqOhM7MQ+IOrq13QADRIHzvzY97SyucZERwLddvzN60FbpklkB0dSdLv ovhemh57TsX4vmc06v3yPGdNy7HrzZcO3tRLQc6sqAoPE9izZ+ZK72Vac+wW7Mlq1RBI pYZj6uRzVeaSd4q1+91EHj8tXrUGT5XJdA5Or2jCnSdrSDGCgoIzJeGlzyL9jiYy+K0Q 6XzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mf++eeayLsVrcTVe6kbYrrnwfp2AEx+dRuICz5iDthY=; b=YZgxOHKNdGtkNKx0y7EwNe0j1eDr1jaT/MzddL0NUXyUjiluekSVUOS8HpKIe82cVR XfTPXLM0ixKTfRbpCL1Nx9nUyYBgQLZpKsV8lk1D7wtXruN03rzRHPiZvB075saRtV2a kQb+9HNhGzzyMAyleL4dp5tEJJ64JTfC9jSAhqbkdlQU3HbTR7YNqj2Auu7wSW3EHmq4 72Bj78dlKEj4fqyLypAO8Iudi+LqEPEQa+Z7MQd2ag4AXPQoY/D0eCcmtXsxc4Vo+L42 fExLEOC9Docx3fiDax5MFKS2abQyTQE4c7uGcRxdHEeoAmGyhnpRhP6fmDrKbhsUvUei ykFA== X-Gm-Message-State: APjAAAVaqu/6gv/oMRHtSADsnaeTKKaHlA1XUuri0EuOXzEpqWfjPA0i HX0WsmD7sIxgE8rswUg80PEbwdjGpNRv X-Google-Smtp-Source: APXvYqzq/ul2JMElKpOHKENYRd3jQpfODd0F76DbNRMFBLppm1MGe/qJ2X3oHiWWCCm1fHfeGC+qHg== X-Received: by 2002:a1c:2645:: with SMTP id m66mr17508997wmm.98.1582499886116; Sun, 23 Feb 2020 15:18:06 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:05 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Ralf Baechle , "David S. Miller" , Jakub Kicinski , linux-hams@vger.kernel.org (open list:NETROM NETWORK LAYER), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Date: Sun, 23 Feb 2020 23:16:52 +0000 Message-Id: <20200223231711.157699-12-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sparse reports a warning at nr_node_stop() warning: context imbalance in nr_node_stop() - wrong count at exit The root cause is the missing annotation at nr_node_stop() Add the missing __releases(&nr_node_list_lock) annotation Signed-off-by: Jules Irenge --- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index fe278fc24153..637a743c060d 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -850,6 +850,7 @@ static void *nr_node_next(struct seq_file *seq, void *v, loff_t *pos) } static void nr_node_stop(struct seq_file *seq, void *v) + __releases(&nr_node_list_lock) { spin_unlock_bh(&nr_node_list_lock); } -- 2.24.1