From: Kaaira Gupta <kgupta@es.iitr.ac.in>
To: Joe Perches <joe@perches.com>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: qlge: emit debug and dump at same level
Date: Mon, 24 Feb 2020 22:17:21 +0530 [thread overview]
Message-ID: <20200224164721.GA7214@kaaira-HP-Pavilion-Notebook> (raw)
In-Reply-To: <84410699e6acbffca960aa2944e9f5869478b178.camel@perches.com>
On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote:
> On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote:
> > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump()
> > instead of existing functions so that the debug and dump are
> > emitted at the same KERN_<LEVEL>
> []
> > diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> []
> > @@ -1324,27 +1324,10 @@ void ql_mpi_core_to_log(struct work_struct *work)
> > {
> > struct ql_adapter *qdev =
> > container_of(work, struct ql_adapter, mpi_core_to_log.work);
> > - u32 *tmp, count;
> > - int i;
> >
> > - count = sizeof(struct ql_mpi_coredump) / sizeof(u32);
> > - tmp = (u32 *)qdev->mpi_coredump;
> > - netif_printk(qdev, drv, KERN_DEBUG, qdev->ndev,
> > - "Core is dumping to log file!\n");
>
> There is no real need to delete this line.
>
> And if you really want to, it'd be better to mention
> the removal in the commit message description.
>
> As is for this change, there is no "debug" and "dump"
> as the commit message description shows, just "dump".
This patch has already been added to the tree, if I amend the commit now
using git rebase, won't it affect the upstream as the SHA-1 of the
commit and it's children will change?
>
>
>
>
next prev parent reply other threads:[~2020-02-24 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 8:24 [PATCH v4] staging: qlge: emit debug and dump at same level Kaaira Gupta
2020-02-24 13:38 ` Joe Perches
2020-02-24 16:47 ` Kaaira Gupta [this message]
2020-02-24 16:54 ` Joe Perches
2020-02-24 17:18 ` Kaaira Gupta
2020-02-24 17:30 ` Joe Perches
2020-03-04 6:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224164721.GA7214@kaaira-HP-Pavilion-Notebook \
--to=kgupta@es.iitr.ac.in \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).