From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51617C35DF2 for ; Tue, 25 Feb 2020 04:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 278BB24680 for ; Tue, 25 Feb 2020 04:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582605815; bh=1VP7h5RXiBX/niAD2aBjvAoddyCRYHuw8utQ8nNFXdA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VFJ5+gjoMmiPv2iyuyL+HX6CpQLDD7SPSNSxQDOhnb3O6+5N/7zwwXvFSrtxUCLqH GmI/f5RBubCrCyoG/m3myb9QZK4sdPWwrJQhlq9io+esNbEQSU/qmT7mxy6LKJL3K/ BWSVkQgP/XXowos6NO4b914LMjUTNdvKJDt6BhAc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728944AbgBYEne (ORCPT ); Mon, 24 Feb 2020 23:43:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:50378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728725AbgBYEne (ORCPT ); Mon, 24 Feb 2020 23:43:34 -0500 Received: from cakuba.hsd1.ca.comcast.net (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F0072467F; Tue, 25 Feb 2020 04:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582605813; bh=1VP7h5RXiBX/niAD2aBjvAoddyCRYHuw8utQ8nNFXdA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SD6fty5SyCkfGSomS+UWHwKHvlcnj6wceZzOPHQh6DujGzptu5xDDSewqOh73fuQR gDQuTrEjTaMe3mEMeBf3W6ozU1ZFx3ccIJPhapzDZrKPSbDctfkDIK2k4U2HZfjcc3 /jWeL9/Nsd1IfqW3jEvXDffbPGfcX4Uhregcdofc= Date: Mon, 24 Feb 2020 20:43:32 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, nhorman@tuxdriver.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, idosch@mellanox.com, mlxsw@mellanox.com Subject: Re: [patch net-next 10/10] selftests: netdevsim: Extend devlink trap test to include flow action cookie Message-ID: <20200224204332.1e126fb4@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20200224210758.18481-11-jiri@resnulli.us> References: <20200224210758.18481-1-jiri@resnulli.us> <20200224210758.18481-11-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 24 Feb 2020 22:07:58 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Extend existing devlink trap test to include metadata type for flow > action cookie. > > Signed-off-by: Jiri Pirko > Signed-off-by: Ido Schimmel > --- > .../testing/selftests/drivers/net/netdevsim/devlink_trap.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh > index f101ab9441e2..437d32bd4cfd 100755 > --- a/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh > +++ b/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh > @@ -103,6 +103,11 @@ trap_metadata_test() > for trap_name in $(devlink_traps_get); do > devlink_trap_metadata_test $trap_name "input_port" > check_err $? "Input port not reported as metadata of trap $trap_name" > + if [ $trap_name == "ingress_flow_action_drop" ] || > + [ $trap_name == "egress_flow_action_drop" ]; then > + devlink_trap_metadata_test $trap_name "flow_action_cookie" > + check_err $? "Flow action cookie not reported as metadata of trap $trap_name" > + fi > done > > log_test "Trap metadata" Oh, this doesn't seem to check the contents of the trap at all, does it?