From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E960DC35E01 for ; Tue, 25 Feb 2020 18:41:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF4412084E for ; Tue, 25 Feb 2020 18:41:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731635AbgBYSl0 (ORCPT ); Tue, 25 Feb 2020 13:41:26 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48494 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731502AbgBYSlZ (ORCPT ); Tue, 25 Feb 2020 13:41:25 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 44A1513B24C6D; Tue, 25 Feb 2020 10:41:25 -0800 (PST) Date: Tue, 25 Feb 2020 10:41:24 -0800 (PST) Message-Id: <20200225.104124.426697838382401029.davem@davemloft.net> To: jiri@resnulli.us Cc: netdev@vger.kernel.org, kuba@kernel.org, ayal@mellanox.com, saeedm@mellanox.com, ranro@mellanox.com, moshe@mellanox.com Subject: Re: [patch net] mlx5: register lag notifier for init network namespace only From: David Miller In-Reply-To: <20200225092546.30710-1-jiri@resnulli.us> References: <20200225092546.30710-1-jiri@resnulli.us> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Feb 2020 10:41:25 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Tue, 25 Feb 2020 10:25:46 +0100 > From: Jiri Pirko > > The current code causes problems when the unregistering netdevice could > be different then the registering one. > > Since the check in mlx5_lag_netdev_event() does not allow any other > network namespace anyway, fix this by registerting the lag notifier > per init network namespace only. > > Fixes: d48834f9d4b4 ("mlx5: Use dev_net netdevice notifier registrations") > Signed-off-by: Jiri Pirko > Tested-by: Aya Levin Saeed, should I apply this directly?