From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: jiri@resnulli.us, netdev@vger.kernel.org, kuba@kernel.org,
intel-wired-lan@lists.osuosl.org
Subject: Re: [patch net-next] iavf: use tc_cls_can_offload_basic() instead of chain check
Date: Tue, 25 Feb 2020 13:20:41 -0800 (PST) [thread overview]
Message-ID: <20200225.132041.1071108395246034738.davem@davemloft.net> (raw)
In-Reply-To: <469b51add666cf3df7381b6409a3972c70024c12.camel@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 25 Feb 2020 13:15:46 -0800
> On Tue, 2020-02-25 at 13:10 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Looks like the iavf code actually experienced a race condition, when
>> a
>> developer took code before the check for chain 0 was put to helper.
>> So use tc_cls_can_offload_basic() helper instead of direct check and
>> move the check to _cb() so this is similar to i40e code.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> Go ahead and pick this up Dave, thanks!
Hmmm, Jiri this doesn't compile?
CC [M] drivers/net/ethernet/intel/iavf/iavf_main.o
drivers/net/ethernet/intel/iavf/iavf_main.c: In function ‘iavf_setup_tc_block_cb’:
drivers/net/ethernet/intel/iavf/iavf_main.c:3089:7: error: implicit declaration of function ‘tc_cls_can_offload_basic’; did you mean ‘tc_cls_common_offload_init’? [-Werror=implicit-function-declaration]
if (!tc_cls_can_offload_basic(adapter->netdev, type_data))
^~~~~~~~~~~~~~~~~~~~~~~~
tc_cls_common_offload_init
Maybe it does depend upon something in the tc filter patch series?
next prev parent reply other threads:[~2020-02-25 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 12:10 [patch net-next] iavf: use tc_cls_can_offload_basic() instead of chain check Jiri Pirko
2020-02-25 19:13 ` David Miller
2020-02-25 21:15 ` Jeff Kirsher
2020-02-25 21:20 ` David Miller [this message]
2020-02-26 7:36 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225.132041.1071108395246034738.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).