From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
To: marcel@holtmann.org, luiz.dentz@gmail.com, alainm@chromium.org
Cc: linux-bluetooth@vger.kernel.org,
chromeos-bluetooth-upstreaming@chromium.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: [RFC PATCH v3 0/5] Bluetooth: Handle system suspend gracefully
Date: Mon, 24 Feb 2020 16:00:31 -0800 [thread overview]
Message-ID: <20200225000036.156250-1-abhishekpandit@chromium.org> (raw)
Hi linux-bluetooth,
This patch series prepares the Bluetooth controller for system suspend
by disconnecting all devices and preparing the event filter and LE
whitelist with devices that can wake the system from suspend.
The main motivation for doing this is so we can enable Bluetooth as
a wake up source during suspend without it being noisy. Bluetooth should
wake the system when a HID device receives user input but otherwise not
send any events to the host.
This patch series was tested on several Chromebooks with both btusb and
hci_serdev on kernel 4.19. The set of tests was basically the following:
* Reconnects after suspend succeed
* HID devices can wake the system from suspend (needs some related bluez
changes to call the Set Wake Capable management command)
* System properly pauses and unpauses discovery + advertising around
suspend
* System does not wake from any events from non wakeable devices
Series 2 has refactored the change into multiple smaller commits as
requested. I tried to simplify some of the whitelist filtering edge
cases but unfortunately it remains quite complex.
Series 3 has refactored it further and should have resolved the
whitelisting complexity in series 2.
Please review and provide any feedback.
Thanks
Abhishek
Changes in v3:
* Refactored to only handle BR/EDR devices
* Split LE changes into its own commit
Changes in v2:
* Moved pm notifier registration into its own patch and moved params out
of separate suspend_state
* Refactored filters and whitelist settings to its own patch
* Refactored update_white_list to have clearer edge cases
* Add connected devices to whitelist (previously missing corner case)
* Refactored pause discovery + advertising into its own patch
Abhishek Pandit-Subedi (5):
Bluetooth: Add mgmt op set_wake_capable
Bluetooth: Handle PM_SUSPEND_PREPARE and PM_POST_SUSPEND
Bluetooth: Handle BR/EDR devices during suspend
Bluetooth: Handle LE devices during suspend
Bluetooth: Pause discovery and advertising during suspend
include/net/bluetooth/hci.h | 17 +-
include/net/bluetooth/hci_core.h | 41 ++++
include/net/bluetooth/mgmt.h | 7 +
net/bluetooth/hci_core.c | 86 ++++++++
net/bluetooth/hci_event.c | 24 +++
net/bluetooth/hci_request.c | 327 ++++++++++++++++++++++++++-----
net/bluetooth/hci_request.h | 2 +
net/bluetooth/mgmt.c | 92 +++++++++
8 files changed, 536 insertions(+), 60 deletions(-)
--
2.25.0.265.gbab2e86ba0-goog
next reply other threads:[~2020-02-25 0:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 0:00 Abhishek Pandit-Subedi [this message]
2020-02-25 0:00 ` [RFC PATCH v3 1/5] Bluetooth: Add mgmt op set_wake_capable Abhishek Pandit-Subedi
2020-02-25 1:34 ` Abhishek Pandit-Subedi
2020-03-02 22:17 ` Marcel Holtmann
2020-03-04 1:11 ` Abhishek Pandit-Subedi
2020-02-25 0:00 ` [RFC PATCH v3 2/5] Bluetooth: Handle PM_SUSPEND_PREPARE and PM_POST_SUSPEND Abhishek Pandit-Subedi
2020-02-25 0:00 ` [RFC PATCH v3 3/5] Bluetooth: Handle BR/EDR devices during suspend Abhishek Pandit-Subedi
2020-02-25 0:00 ` [RFC PATCH v3 4/5] Bluetooth: Handle LE " Abhishek Pandit-Subedi
2020-02-25 0:00 ` [RFC PATCH v3 5/5] Bluetooth: Pause discovery and advertising " Abhishek Pandit-Subedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225000036.156250-1-abhishekpandit@chromium.org \
--to=abhishekpandit@chromium.org \
--cc=alainm@chromium.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).