netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, kuba@kernel.org, ayal@mellanox.com,
	saeedm@mellanox.com, ranro@mellanox.com, moshe@mellanox.com
Subject: Re: [patch net] mlx5: register lag notifier for init network namespace only
Date: Wed, 26 Feb 2020 16:52:39 -0800 (PST)	[thread overview]
Message-ID: <20200226.165239.940350760077316036.davem@davemloft.net> (raw)
In-Reply-To: <20200226.165048.2228405992426450518.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 26 Feb 2020 16:50:48 -0800 (PST)

> From: Jiri Pirko <jiri@resnulli.us>
> Date: Tue, 25 Feb 2020 10:25:46 +0100
> 
>> From: Jiri Pirko <jiri@mellanox.com>
>> 
>> The current code causes problems when the unregistering netdevice could
>> be different then the registering one.
>> 
>> Since the check in mlx5_lag_netdev_event() does not allow any other
>> network namespace anyway, fix this by registerting the lag notifier
>> per init network namespace only.
>> 
>> Fixes: d48834f9d4b4 ("mlx5: Use dev_net netdevice notifier registrations")
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>> Tested-by: Aya Levin <ayal@mellanox.com>
> 
> Applied, thank you.

Actually, you need to respin this and fix the following warning:

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_uplink_rep_disable’:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1864:21: warning: unused variable ‘netdev’ [-Wunused-variable]
  struct net_device *netdev = priv->netdev;
                     ^~~~~~

You can retain Saeed's ACK when you do this.

Thank you.

  reply	other threads:[~2020-02-27  0:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25  9:25 [patch net] mlx5: register lag notifier for init network namespace only Jiri Pirko
2020-02-25 18:41 ` David Miller
2020-02-25 22:41   ` Saeed Mahameed
2020-02-27  0:50 ` David Miller
2020-02-27  0:52   ` David Miller [this message]
2020-02-27  6:19     ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226.165239.940350760077316036.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ayal@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=moshe@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ranro@mellanox.com \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).