From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 4/9] sysfs: add sysfs_change_owner()
Date: Wed, 26 Feb 2020 09:15:33 +0100 [thread overview]
Message-ID: <20200226081533.GC24447@kroah.com> (raw)
In-Reply-To: <20200225131938.120447-5-christian.brauner@ubuntu.com>
On Tue, Feb 25, 2020 at 02:19:33PM +0100, Christian Brauner wrote:
> Add a helper to change the owner of sysfs objects.
> This function will be used to correctly account for kobject ownership
> changes, e.g. when moving network devices between network namespaces.
>
> This mirrors how a kobject is added through driver core which in its guts is
> done via kobject_add_internal() which in summary creates the main directory via
> create_dir(), populates that directory with the groups associated with the
> ktype of the kobject (if any) and populates the directory with the basic
> attributes associated with the ktype of the kobject (if any). These are the
> basic steps that are associated with adding a kobject in sysfs.
> Any additional properties are added by the specific subsystem itself (not by
> driver core) after it has registered the device. So for the example of network
> devices, a network device will e.g. register a queue subdirectory under the
> basic sysfs directory for the network device and than further subdirectories
> within that queues subdirectory. But that is all specific to network devices
> and they call the corresponding sysfs functions to do that directly when they
> create those queue objects. So anything that a subsystem adds outside of what
> driver core does must also be changed by it (That's already true for removal of
> files it created outside of driver core.) and it's the same for ownership
> changes.
>
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Thanks for the documentation update, looks good:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2020-02-26 8:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 13:19 [PATCH v6 0/9] net: fix sysfs permssions when device changes network Christian Brauner
2020-02-25 13:19 ` [PATCH v6 1/9] sysfs: add sysfs_file_change_owner() Christian Brauner
2020-02-26 8:13 ` Greg Kroah-Hartman
2020-02-25 13:19 ` [PATCH v6 2/9] sysfs: add sysfs_link_change_owner() Christian Brauner
2020-02-26 8:14 ` Greg Kroah-Hartman
2020-02-25 13:19 ` [PATCH v6 3/9] sysfs: add sysfs_group{s}_change_owner() Christian Brauner
2020-02-25 13:19 ` [PATCH v6 4/9] sysfs: add sysfs_change_owner() Christian Brauner
2020-02-26 8:15 ` Greg Kroah-Hartman [this message]
2020-02-25 13:19 ` [PATCH v6 5/9] device: add device_change_owner() Christian Brauner
2020-02-26 8:16 ` Greg Kroah-Hartman
2020-02-25 13:19 ` [PATCH v6 6/9] drivers/base/power: add dpm_sysfs_change_owner() Christian Brauner
2020-02-25 16:13 ` Rafael J. Wysocki
2020-02-26 8:16 ` Greg Kroah-Hartman
2020-02-25 13:19 ` [PATCH v6 7/9] net-sysfs: add netdev_change_owner() Christian Brauner
2020-02-25 13:19 ` [PATCH v6 8/9] net-sysfs: add queue_change_owner() Christian Brauner
2020-02-25 13:19 ` [PATCH v6 9/9] net: fix sysfs permssions when device changes network namespace Christian Brauner
2020-02-26 8:17 ` [PATCH v6 0/9] net: fix sysfs permssions when device changes network Greg Kroah-Hartman
2020-02-27 1:37 ` David Miller
2020-02-27 3:06 ` David Miller
2020-02-27 3:21 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226081533.GC24447@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).