From: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
To: <edumazet@google.com>
Cc: <davem@davemloft.net>, <kuni1840@gmail.com>,
<kuniyu@amazon.co.jp>, <kuznet@ms2.inr.ac.ru>,
<netdev@vger.kernel.org>, <osa-contribution-log@amazon.com>,
<yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH v2 net-next 3/3] tcp: Prevent port hijacking when ports are exhausted.
Date: Sun, 1 Mar 2020 03:37:17 +0900 [thread overview]
Message-ID: <20200229183717.14616-1-kuniyu@amazon.co.jp> (raw)
In-Reply-To: <CANn89i+m9yKkaVLUm9P8+gTSOMtvrJgsvHfKAjXCZ5_9Wf0-9w@mail.gmail.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 26 Feb 2020 09:47:26 -0800
> This changelog is rather confusing, and your patch does not solve this
> precise problem.
> Patch titles are important, you are claiming something, but I fail to
> see how the patch solves the problem stated in the title.
>
> Please be more specific, and add tests officially, in tools/testing/selftests/
>
>
> > If both of SO_REUSEADDR and SO_REUSEPORT are enabled, the restriction of
> > SO_REUSEPORT should be taken into account so that can only one socket be in
> > TCP_LISTEN.
>
> Sorry, I do not understand this. If I do not understand the sentence,
> I do not read the patch
> changing one piece of code that has been very often broken in the past.
>
> Please spend time on the changelog to give the exact outcome and goals.
I am so sorry that I wrote the changelog roughly. I appreciate for your
kind advice. I could rewrite more precise description of this issue and
respin these patches with tests.
[PATCH v3 net-next 0/4] Improve bind(addr, 0) behaviour.
https://lore.kernel.org/netdev/20200229113554.78338-1-kuniyu@amazon.co.jp/
Thank you so much!
prev parent reply other threads:[~2020-02-29 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 7:46 [PATCH v2 net-next 0/3] Improve bind(addr, 0) behaviour Kuniyuki Iwashima
2020-02-26 7:46 ` [PATCH v2 net-next 1/3] tcp: Remove unnecessary conditions in inet_csk_bind_conflict() Kuniyuki Iwashima
2020-02-26 7:46 ` [PATCH v2 net-next 2/3] tcp: bind(addr, 0) remove the SO_REUSEADDR restriction when ephemeral ports are exhausted Kuniyuki Iwashima
2020-02-26 7:46 ` [PATCH v2 net-next 3/3] tcp: Prevent port hijacking when " Kuniyuki Iwashima
2020-02-26 17:47 ` Eric Dumazet
2020-02-29 18:37 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200229183717.14616-1-kuniyu@amazon.co.jp \
--to=kuniyu@amazon.co.jp \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuni1840@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=osa-contribution-log@amazon.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).