From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CF8C3F2CD for ; Sat, 29 Feb 2020 19:32:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DA5B24688 for ; Sat, 29 Feb 2020 19:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727335AbgB2TcZ (ORCPT ); Sat, 29 Feb 2020 14:32:25 -0500 Received: from correo.us.es ([193.147.175.20]:42990 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbgB2TcZ (ORCPT ); Sat, 29 Feb 2020 14:32:25 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4BA07C22F6 for ; Sat, 29 Feb 2020 20:32:12 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3E379DA3A1 for ; Sat, 29 Feb 2020 20:32:12 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 2A9A8DA39F; Sat, 29 Feb 2020 20:32:12 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2F602DA7B2; Sat, 29 Feb 2020 20:32:10 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Sat, 29 Feb 2020 20:32:10 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [84.78.24.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id CA50942EE38F; Sat, 29 Feb 2020 20:32:09 +0100 (CET) Date: Sat, 29 Feb 2020 20:32:18 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, saeedm@mellanox.com, leon@kernel.org, michael.chan@broadcom.com, vishal@chelsio.com, jeffrey.t.kirsher@intel.com, idosch@mellanox.com, aelior@marvell.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, ecree@solarflare.com, mlxsw@mellanox.com Subject: Re: [patch net-next v2 08/12] flow_offload: introduce "immediate" HW stats type and allow it in mlxsw Message-ID: <20200229193217.ejk3gbwhjcnxlk3c@salvia> References: <20200228172505.14386-1-jiri@resnulli.us> <20200228172505.14386-9-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200228172505.14386-9-jiri@resnulli.us> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 28, 2020 at 06:25:01PM +0100, Jiri Pirko wrote: [...] > @@ -31,7 +31,8 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp, > > act = flow_action_first_entry_get(flow_action); > switch (act->hw_stats_type) { > - case FLOW_ACTION_HW_STATS_TYPE_ANY: > + case FLOW_ACTION_HW_STATS_TYPE_ANY: /* fall-through */ > + case FLOW_ACTION_HW_STATS_TYPE_IMMEDIATE: This TYPE_ANY mean that driver picks the counter type for you? Otherwise, users will not have a way to know how to interpret what kind of counter this is.