From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, michael@walle.cc
Subject: Re: [PATCH net] net: phy: avoid clearing PHY interrupts twice in irq handler
Date: Sun, 01 Mar 2020 19:05:00 -0800 (PST) [thread overview]
Message-ID: <20200301.190500.946623747700619111.davem@davemloft.net> (raw)
In-Reply-To: <2f468a46-e966-761c-8466-51601d8f11a3@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 1 Mar 2020 21:36:09 +0100
> On all PHY drivers that implement did_interrupt() reading the interrupt
> status bits clears them. This means we may loose an interrupt that
> is triggered between calling did_interrupt() and phy_clear_interrupt().
> As part of the fix make it a requirement that did_interrupt() clears
> the interrupt.
>
> The Fixes tag refers to the first commit where the patch applies
> cleanly.
>
> Fixes: 49644e68f472 ("net: phy: add callback for custom interrupt handler to struct phy_driver")
> Reported-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-03-02 3:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 20:36 [PATCH net] net: phy: avoid clearing PHY interrupts twice in irq handler Heiner Kallweit
2020-03-01 22:52 ` Michael Walle
2020-03-01 23:20 ` Heiner Kallweit
2020-03-04 12:13 ` Heiner Kallweit
2020-03-04 13:02 ` Michael Walle
2020-03-02 3:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301.190500.946623747700619111.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).