From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDA8C3F2CD for ; Sun, 1 Mar 2020 16:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03B6521775 for ; Sun, 1 Mar 2020 16:50:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Mxb/3CfW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbgCAQuY (ORCPT ); Sun, 1 Mar 2020 11:50:24 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40488 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbgCAQuX (ORCPT ); Sun, 1 Mar 2020 11:50:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AGfy1w0+4VKRX6In5CqQMtisuSIfijuxb2F01OkPP90=; b=Mxb/3CfW2heID9WUBvuOk9XU5i RTWwNhlc0i1U1nU3eUWylEkSYrYiczhen+DWhGibaKDERGQm+pLXaT30U9X0AFsRz4zMipqRQMqLe 5T21E9QWAxKNR0//oNJjXmBR56vwclTVJ5/DeWkv66RUTzJ5CFyZakk5QsM2yT61k7f0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j8RnG-0008J1-KB; Sun, 01 Mar 2020 17:50:18 +0100 Date: Sun, 1 Mar 2020 17:50:18 +0100 From: Andrew Lunn To: Dajun Jin Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, robh+dt@kernel.org, frowand.list@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] drivers/of/of_mdio.c:fix of_mdiobus_register() Message-ID: <20200301165018.GN6305@lunn.ch> References: <20200301164138.8542-1-adajunjin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200301164138.8542-1-adajunjin@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 02, 2020 at 12:41:38AM +0800, Dajun Jin wrote: > when registers a phy_device successful, should terminate the loop > or the phy_device would be registered in other addr. > > Signed-off-by: Dajun Jin > --- > drivers/of/of_mdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > index 8270bbf505fb..9f982c0627a0 100644 > --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -306,6 +306,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) > rc = of_mdiobus_register_phy(mdio, child, addr); > if (rc && rc != -ENODEV) > goto unregister; > + break; > } > } > } Hi Dajun What problem are you seeing? You explanation needs to be better. I'm guessing you have two or more PHYs on the bus, without reg properties? Andrew