From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, valex@mellanox.com,
linyunsheng@huawei.com, lihong.yang@intel.com, kuba@kernel.org
Subject: Re: [RFC PATCH v2 11/22] devlink: add functions to take snapshot while locked
Date: Mon, 2 Mar 2020 18:43:55 +0100 [thread overview]
Message-ID: <20200302174355.GG2168@nanopsycho> (raw)
In-Reply-To: <20200214232223.3442651-12-jacob.e.keller@intel.com>
Sat, Feb 15, 2020 at 12:22:10AM CET, jacob.e.keller@intel.com wrote:
>A future change is going to add a new devlink command to request
>a snapshot on demand. This function will want to call the
>devlink_region_snapshot_id_get and devlink_region_snapshot_create
>functions while already holding the devlink instance lock.
>
>Extract the logic of these two functions into static functions prefixed
>by `__` to indicate they are internal helper functions. Modify the
>original functions to be implemented in terms of the new locked
>functions.
>
>Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
>---
> net/core/devlink.c | 93 ++++++++++++++++++++++++++++++----------------
> 1 file changed, 61 insertions(+), 32 deletions(-)
>
>diff --git a/net/core/devlink.c b/net/core/devlink.c
>index fef93f48028c..0e94887713f4 100644
>--- a/net/core/devlink.c
>+++ b/net/core/devlink.c
>@@ -3760,6 +3760,65 @@ static void devlink_nl_region_notify(struct devlink_region *region,
> nlmsg_free(msg);
> }
>
>+/**
>+ * __devlink_region_snapshot_id_get - get snapshot ID
>+ * @devlink: devlink instance
>+ *
>+ * Returns a new snapshot id. Must be called while holding the
>+ * devlink instance lock.
>+ */
You don't need this docu comment for static functions.
>+static u32 __devlink_region_snapshot_id_get(struct devlink *devlink)
>+{
>+ lockdep_assert_held(&devlink->lock);
>+ return ++devlink->snapshot_id;
>+}
>+
>+/**
>+ * __devlink_region_snapshot_create - create a new snapshot
>+ * This will add a new snapshot of a region. The snapshot
>+ * will be stored on the region struct and can be accessed
>+ * from devlink. This is useful for future analyses of snapshots.
>+ * Multiple snapshots can be created on a region.
>+ * The @snapshot_id should be obtained using the getter function.
>+ *
>+ * Must be called only while holding the devlink instance lock.
>+ *
>+ * @region: devlink region of the snapshot
>+ * @data: snapshot data
>+ * @snapshot_id: snapshot id to be created
>+ */
>+static int
>+__devlink_region_snapshot_create(struct devlink_region *region,
>+ u8 *data, u32 snapshot_id)
>+{
>+ struct devlink *devlink = region->devlink;
>+ struct devlink_snapshot *snapshot;
>+
>+ lockdep_assert_held(&devlink->lock);
>+
>+ /* check if region can hold one more snapshot */
>+ if (region->cur_snapshots == region->max_snapshots)
>+ return -ENOMEM;
>+
>+ if (devlink_region_snapshot_get_by_id(region, snapshot_id))
>+ return -EEXIST;
>+
>+ snapshot = kzalloc(sizeof(*snapshot), GFP_KERNEL);
>+ if (!snapshot)
>+ return -ENOMEM;
>+
>+ snapshot->id = snapshot_id;
>+ snapshot->region = region;
>+ snapshot->data = data;
>+
>+ list_add_tail(&snapshot->list, ®ion->snapshot_list);
>+
>+ region->cur_snapshots++;
>+
>+ devlink_nl_region_notify(region, snapshot, DEVLINK_CMD_REGION_NEW);
>+ return 0;
>+}
>+
> static void devlink_region_snapshot_del(struct devlink_region *region,
> struct devlink_snapshot *snapshot)
> {
>@@ -7618,7 +7677,7 @@ u32 devlink_region_snapshot_id_get(struct devlink *devlink)
> u32 id;
>
> mutex_lock(&devlink->lock);
>- id = ++devlink->snapshot_id;
>+ id = __devlink_region_snapshot_id_get(devlink);
> mutex_unlock(&devlink->lock);
>
> return id;
>@@ -7641,42 +7700,12 @@ int devlink_region_snapshot_create(struct devlink_region *region,
> u8 *data, u32 snapshot_id)
> {
> struct devlink *devlink = region->devlink;
>- struct devlink_snapshot *snapshot;
> int err;
>
> mutex_lock(&devlink->lock);
>-
>- /* check if region can hold one more snapshot */
>- if (region->cur_snapshots == region->max_snapshots) {
>- err = -ENOMEM;
>- goto unlock;
>- }
>-
>- if (devlink_region_snapshot_get_by_id(region, snapshot_id)) {
>- err = -EEXIST;
>- goto unlock;
>- }
>-
>- snapshot = kzalloc(sizeof(*snapshot), GFP_KERNEL);
>- if (!snapshot) {
>- err = -ENOMEM;
>- goto unlock;
>- }
>-
>- snapshot->id = snapshot_id;
>- snapshot->region = region;
>- snapshot->data = data;
>-
>- list_add_tail(&snapshot->list, ®ion->snapshot_list);
>-
>- region->cur_snapshots++;
>-
>- devlink_nl_region_notify(region, snapshot, DEVLINK_CMD_REGION_NEW);
>+ err = __devlink_region_snapshot_create(region, data, snapshot_id);
> mutex_unlock(&devlink->lock);
>- return 0;
>
>-unlock:
>- mutex_unlock(&devlink->lock);
> return err;
> }
> EXPORT_SYMBOL_GPL(devlink_region_snapshot_create);
>--
>2.25.0.368.g28a2d05eebfb
>
next prev parent reply other threads:[~2020-03-02 17:44 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 23:21 [RFC PATCH v2 00/22] devlink region updates Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 01/22] ice: use __le16 types for explicitly Little Endian values Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 02/22] ice: create function to read a section of the NVM and Shadow RAM Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 03/22] ice: implement full NVM read from ETHTOOL_GEEPROM Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 04/22] ice: enable initial devlink support Jacob Keller
2020-03-02 16:30 ` Jiri Pirko
2020-03-02 19:29 ` Jacob Keller
2020-03-03 13:47 ` Jiri Pirko
2020-03-03 17:53 ` Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 05/22] ice: rename variables used for Option ROM version Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 06/22] ice: add basic handler for devlink .info_get Jacob Keller
2020-02-19 2:45 ` Jakub Kicinski
2020-02-19 17:33 ` Jacob Keller
2020-02-19 19:57 ` Jakub Kicinski
2020-02-19 21:37 ` Jacob Keller
2020-02-19 23:47 ` Jakub Kicinski
2020-02-20 0:06 ` Jacob Keller
2020-02-21 22:11 ` Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 07/22] ice: add board identifier info to " Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 08/22] devlink: prepare to support region operations Jacob Keller
2020-03-02 17:42 ` Jiri Pirko
2020-02-14 23:22 ` [RFC PATCH v2 09/22] devlink: convert snapshot destructor callback to region op Jacob Keller
2020-03-02 17:42 ` Jiri Pirko
2020-02-14 23:22 ` [RFC PATCH v2 10/22] devlink: trivial: fix tab in function documentation Jacob Keller
2020-03-02 17:42 ` Jiri Pirko
2020-02-14 23:22 ` [RFC PATCH v2 11/22] devlink: add functions to take snapshot while locked Jacob Keller
2020-03-02 17:43 ` Jiri Pirko [this message]
2020-03-02 22:25 ` Jacob Keller
2020-03-03 8:41 ` Jiri Pirko
2020-02-14 23:22 ` [RFC PATCH v2 12/22] devlink: convert snapshot id getter to return an error Jacob Keller
2020-03-02 17:44 ` Jiri Pirko
2020-02-14 23:22 ` [RFC PATCH v2 13/22] devlink: track snapshot ids using an IDR and refcounts Jacob Keller
2020-02-18 21:44 ` Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 14/22] devlink: implement DEVLINK_CMD_REGION_NEW Jacob Keller
2020-03-02 17:41 ` Jiri Pirko
2020-03-02 19:38 ` Jacob Keller
2020-03-03 9:30 ` Jiri Pirko
2020-03-03 17:51 ` Jacob Keller
2020-03-04 11:58 ` Jiri Pirko
2020-03-04 17:43 ` Jacob Keller
2020-03-05 6:41 ` Jiri Pirko
2020-03-05 22:33 ` Jacob Keller
2020-03-06 6:16 ` Jiri Pirko
2020-03-02 22:11 ` Jacob Keller
2020-03-02 22:14 ` Jacob Keller
2020-03-02 22:35 ` Jacob Keller
2020-03-03 9:31 ` Jiri Pirko
2020-02-14 23:22 ` [RFC PATCH v2 15/22] netdevsim: support taking immediate snapshot via devlink Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 16/22] devlink: simplify arguments for read_snapshot_fill Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 17/22] devlink: use min_t to calculate data_size Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 18/22] devlink: report extended error message in region_read_dumpit Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 19/22] devlink: remove unnecessary parameter from chunk_fill function Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 20/22] devlink: refactor region_read_snapshot_fill to use a callback function Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 21/22] devlink: support directly reading from region memory Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 22/22] ice: add a devlink region to dump shadow RAM contents Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 1/2] devlink: add support for DEVLINK_CMD_REGION_NEW Jacob Keller
2020-02-14 23:22 ` [RFC PATCH v2 2/2] devlink: stop requiring snapshot for regions Jacob Keller
2020-03-02 16:27 ` [RFC PATCH v2 00/22] devlink region updates Jiri Pirko
2020-03-02 19:27 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302174355.GG2168@nanopsycho \
--to=jiri@resnulli.us \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=lihong.yang@intel.com \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).