From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Dajun Jin <adajunjin@gmail.com>,
hkallweit1@gmail.com, robh+dt@kernel.org, frowand.list@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] drivers/of/of_mdio.c:fix of_mdiobus_register()
Date: Mon, 2 Mar 2020 18:38:33 +0000 [thread overview]
Message-ID: <20200302183833.GJ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200302175759.GD24912@lunn.ch>
On Mon, Mar 02, 2020 at 06:57:59PM +0100, Andrew Lunn wrote:
> Hi Dajun
>
> > This is my test in Xilinx zcu106 board.
> >
> > dts is liks this:
> > ethernet@ff0e0000 {
> > compatible = "cdns,zynqmp-gem", "cdns,gem";
> > status = "okay";
> > ...
> >
> > phy@0 {
> > ti,rx-internal-delay = <0x8>;
> > ti,tx-internal-delay = <0xa>;
> > ti,fifo-depth = <0x1>;
> > ti,rxctrl-strap-worka;
> > linux,phandle = <0x12>;
> > phandle = <0x12>;
Isn't dtc going to complain about this? The node name has an address,
but there's no reg property. If there's no reg property, shouldn't it
be just "phy" ?
The above doesn't look like the original .dts file itself either, but
a .dtb translated back to a .dts - note the numeric phandle properties
and presence of "linux,phandle".
ethernet-phy.yaml also says:
required:
- reg
so arguably the above doesn't conform to what we expect?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-03-02 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 16:41 [PATCH] drivers/of/of_mdio.c:fix of_mdiobus_register() Dajun Jin
2020-03-01 16:50 ` Andrew Lunn
2020-03-02 17:29 ` Dajun Jin
2020-03-02 17:57 ` Andrew Lunn
2020-03-02 18:38 ` Russell King - ARM Linux admin [this message]
2020-03-03 4:24 ` Dajun Jin
2020-03-03 22:02 ` Andrew Lunn
2020-03-04 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302183833.GJ25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=adajunjin@gmail.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).