From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28558C3F2CE for ; Wed, 4 Mar 2020 21:26:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07E112084E for ; Wed, 4 Mar 2020 21:26:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387398AbgCDV0Q (ORCPT ); Wed, 4 Mar 2020 16:26:16 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46298 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgCDV0P (ORCPT ); Wed, 4 Mar 2020 16:26:15 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C558715ABF01F; Wed, 4 Mar 2020 13:26:14 -0800 (PST) Date: Wed, 04 Mar 2020 13:26:11 -0800 (PST) Message-Id: <20200304.132611.1082983925572874313.davem@davemloft.net> To: kuba@kernel.org Cc: lesliemonis@gmail.com, netdev@vger.kernel.org, tahiliani@nitk.edu.in, gautamramk@gmail.com Subject: Re: [PATCH net-next v2 0/4] pie: minor improvements From: David Miller In-Reply-To: <20200304124917.0fbba371@kicinski-fedora-PC1C0HJN> References: <20200304185602.2540-1-lesliemonis@gmail.com> <20200304124917.0fbba371@kicinski-fedora-PC1C0HJN> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Mar 2020 13:26:15 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Wed, 4 Mar 2020 12:49:17 -0800 > On Thu, 5 Mar 2020 00:25:58 +0530 Leslie Monis wrote: >> This patch series includes the following minor changes with >> respect to the PIE/FQ-PIE qdiscs: >> >> - Patch 1 removes some ambiguity by using the term "backlog" >> instead of "qlen" when referring to the queue length >> in bytes. >> - Patch 2 removes redundant type casting on two expressions. >> - Patch 3 removes the pie_vars->accu_prob_overflows variable >> without affecting the precision in calculations and >> makes the size of the pie_vars structure exactly 64 >> bytes. >> - Patch 4 realigns a comment affected by a change in patch 3. >> >> Changes from v1 to v2: >> - Kept 8 as the argument to prandom_bytes() instead of changing it >> to 7 as suggested by David Miller. > > I was wondering if patch 3 changes make user-visible changes but it > seems those should be only slight accuracy adjustments, so LGTM. FWIW: > > Reviewed-by: Jakub Kicinski Series applied, thanks everyone.