From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E53C3F2D1 for ; Wed, 4 Mar 2020 06:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E208215A4 for ; Wed, 4 Mar 2020 06:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583304588; bh=VK53u2VxkYUENGgHTPFGpT3Z/fpLjjPmXcKQ3gcUtws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KAakjvqbEZmpd6pCNc5Sfx2SeRNGHeW9KjKJ5JwGLjTneLFpmM6jUvHRPvZBUkiDz Vh/XYjum6bFrQYXEieUEKD4iy+gZJN95IPjvy22dZr25cMOxY6fb628fMcUlXz2Etp BF7IPkZY3+jxi6j5/wf17/5XdDgPmRrQBVd85aTY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728098AbgCDGtq (ORCPT ); Wed, 4 Mar 2020 01:49:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:56654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725271AbgCDGtp (ORCPT ); Wed, 4 Mar 2020 01:49:45 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBE3E2146E; Wed, 4 Mar 2020 06:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583304585; bh=VK53u2VxkYUENGgHTPFGpT3Z/fpLjjPmXcKQ3gcUtws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+kwW6KvpMnnUi3CM3rOFD+6kThqvnEFjb1p+czVRydBv93/KSXzGe2IYFoW676Fv pH2x4cytTMjT9gRUPVeCMQ+P04yFBpP+CZWgtITnnRIko9PnsJXb6Tw5ZE2IyElK15 1/ziS9d0t+rBiXatxi4PMTLBHTJDG2uW3BZ39/MI= Date: Wed, 4 Mar 2020 07:49:43 +0100 From: Greg Kroah-Hartman To: Kaaira Gupta Cc: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: qlge: emit debug and dump at same level Message-ID: <20200304064943.GA1232764@kroah.com> References: <20200224082448.GA6826@kaaira-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224082448.GA6826@kaaira-HP-Pavilion-Notebook> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 24, 2020 at 01:54:48PM +0530, Kaaira Gupta wrote: > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > instead of existing functions so that the debug and dump are > emitted at the same KERN_ > > Signed-off-by: Kaaira Gupta > --- > > changes since v1: make code of ql_mpi_core_to_log() simpler. > changes since v2: directly call the function instead of defining a > macro. > changes since v3: Remove prefix string. > > ---- > --- > drivers/staging/qlge/qlge_dbg.c | 23 +++-------------------- > 1 file changed, 3 insertions(+), 20 deletions(-) Does not apply to my tree :(