From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree@solarflare.com>
Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Michal Kubecek <mkubecek@suse.cz>, <davem@davemloft.net>,
<thomas.lendacky@amd.com>, <benve@cisco.com>, <_govind@gmx.com>,
<pkaustub@cisco.com>, <peppe.cavallaro@st.com>,
<alexandre.torgue@st.com>, <joabreu@synopsys.com>,
<snelson@pensando.io>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <jeffrey.t.kirsher@intel.com>,
<jacob.e.keller@intel.com>, <michael.chan@broadcom.com>,
<saeedm@mellanox.com>, <leon@kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters
Date: Wed, 4 Mar 2020 10:28:40 -0800 [thread overview]
Message-ID: <20200304102840.3fb9eef2@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <410f35ef-b023-1c24-f7e7-2724bae121ff@solarflare.com>
On Wed, 4 Mar 2020 18:16:13 +0000 Edward Cree wrote:
> On 04/03/2020 18:12, Alexander Duyck wrote:
> > So one thing I just wanted to point out. The used_types won't necessarily
> > be correct because it is only actually checking for non-zero types. There
> > are some of these values where a zero is a valid input
> Presumably in the netlink ethtool world we'll want to instead check if
> the attribute was passed? Not sure but that might affect what semantics
> we want to imply now.
I mean... it's just a local variable in a helper... :)
I think netlink will need its own helper based on attribute presence,
as you said.
next prev parent reply other threads:[~2020-03-04 18:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 4:33 [PATCH net-next v2 00/12] ethtool: consolidate parameter checking for irq coalescing Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters Jakub Kicinski
2020-03-04 7:59 ` Michal Kubecek
2020-03-04 18:00 ` Jakub Kicinski
2020-03-04 18:12 ` Alexander Duyck
2020-03-04 18:16 ` Edward Cree
2020-03-04 18:28 ` Jakub Kicinski [this message]
2020-03-04 18:34 ` Michal Kubecek
2020-03-04 18:27 ` Jakub Kicinski
2020-03-04 18:50 ` Alexander Duyck
2020-03-05 4:34 ` Jakub Kicinski
2020-03-04 18:36 ` Michal Kubecek
2020-03-04 21:22 ` Jacob Keller
2020-03-04 21:15 ` Jacob Keller
2020-03-04 4:33 ` [PATCH net-next v2 02/12] xgbe: let core reject the unsupported " Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 03/12] enic: " Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 04/12] stmmac: " Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 05/12] nfp: " Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 06/12] ionic: " Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 07/12] hisilicon: " Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 08/12] ice: " Jakub Kicinski
2020-03-04 18:08 ` Jeff Kirsher
2020-03-04 21:20 ` Jacob Keller
2020-03-04 4:33 ` [PATCH net-next v2 09/12] bnxt: reject unsupported coalescing params Jakub Kicinski
2020-03-04 6:16 ` Michael Chan
2020-03-04 4:33 ` [PATCH net-next v2 10/12] mlx5: " Jakub Kicinski
2020-03-04 4:33 ` [PATCH net-next v2 11/12] e1000e: " Jakub Kicinski
2020-03-04 18:08 ` Jeff Kirsher
2020-03-04 4:33 ` [PATCH net-next v2 12/12] virtio_net: " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304102840.3fb9eef2@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=_govind@gmx.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joabreu@synopsys.com \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=pkaustub@cisco.com \
--cc=saeedm@mellanox.com \
--cc=salil.mehta@huawei.com \
--cc=snelson@pensando.io \
--cc=thomas.lendacky@amd.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).