From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzkaller@googlegroups.com
Subject: Re: [PATCH net] slip: make slhc_compress() more robust against malicious packets
Date: Thu, 05 Mar 2020 12:00:27 -0800 (PST) [thread overview]
Message-ID: <20200305.120027.821059280923943275.davem@davemloft.net> (raw)
In-Reply-To: <20200304235143.214557-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 4 Mar 2020 15:51:43 -0800
> Before accessing various fields in IPV4 network header
> and TCP header, make sure the packet :
>
> - Has IP version 4 (ip->version == 4)
> - Has not a silly network length (ip->ihl >= 5)
> - Is big enough to hold network and transport headers
> - Has not a silly TCP header size (th->doff >= sizeof(struct tcphdr) / 4)
>
> syzbot reported :
...
> Fixes: b5451d783ade ("slip: Move the SLIP drivers")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-03-05 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 23:51 [PATCH net] slip: make slhc_compress() more robust against malicious packets Eric Dumazet
2020-03-05 20:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305.120027.821059280923943275.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).