From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzkaller@googlegroups.com, j.vosburgh@gmail.com,
vfalico@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH net] bonding/alb: make sure arp header is pulled before accessing it
Date: Fri, 06 Mar 2020 22:01:23 -0800 (PST) [thread overview]
Message-ID: <20200306.220123.221515051483240141.davem@davemloft.net> (raw)
In-Reply-To: <20200304173216.98819-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 4 Mar 2020 09:32:16 -0800
> Similar to commit 38f88c454042 ("bonding/alb: properly access headers
> in bond_alb_xmit()"), we need to make sure arp header was pulled
> in skb->head before blindly accessing it in rlb_arp_xmit().
>
> Remove arp_pkt() private helper, since it is more readable/obvious
> to have the following construct back to back :
>
> if (!pskb_network_may_pull(skb, sizeof(*arp)))
> return NULL;
> arp = (struct arp_pkt *)skb_network_header(skb);
>
> syzbot reported :
...
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2020-03-07 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 17:32 [PATCH net] bonding/alb: make sure arp header is pulled before accessing it Eric Dumazet
2020-03-07 6:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306.220123.221515051483240141.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).