From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0DC2C10F25 for ; Mon, 9 Mar 2020 04:09:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6C5420665 for ; Mon, 9 Mar 2020 04:09:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726165AbgCIEJP (ORCPT ); Mon, 9 Mar 2020 00:09:15 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53906 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbgCIEJO (ORCPT ); Mon, 9 Mar 2020 00:09:14 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 46466158B55F7; Sun, 8 Mar 2020 21:09:13 -0700 (PDT) Date: Sun, 08 Mar 2020 21:09:12 -0700 (PDT) Message-Id: <20200308.210912.1633299574639128341.davem@davemloft.net> To: jiri@resnulli.us Cc: netdev@vger.kernel.org, kuba@kernel.org, saeedm@mellanox.com, leon@kernel.org, michael.chan@broadcom.com, vishal@chelsio.com, jeffrey.t.kirsher@intel.com, idosch@mellanox.com, aelior@marvell.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, pablo@netfilter.org, ecree@solarflare.com, mlxsw@mellanox.com Subject: Re: [patch net-next v4 00/10] net: allow user specify TC action HW stats type From: David Miller In-Reply-To: <20200307114020.8664-1-jiri@resnulli.us> References: <20200307114020.8664-1-jiri@resnulli.us> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 08 Mar 2020 21:09:14 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Sat, 7 Mar 2020 12:40:10 +0100 > Currently, when user adds a TC action and the action gets offloaded, > the user expects the HW stats to be counted and included in stats dump. > However, since drivers may implement different types of counting, there > is no way to specify which one the user is interested in. > > For example for mlx5, only delayed counters are available as the driver > periodically polls for updated stats. > > In case of mlxsw, the counters are queried on dump time. However, the > HW resources for this type of counters is quite limited (couple of > thousands). This limits the amount of supported offloaded filters > significantly. Without counter assigned, the HW is capable to carry > millions of those. > > On top of that, mlxsw HW is able to support delayed counters as well in > greater numbers. That is going to be added in a follow-up patch. > > This patchset allows user to specify one of the following types of HW > stats for added action: > immediate - queried during dump time > delayed - polled from HW periodically or sent by HW in async manner > disabled - no stats needed > > Note that if "hw_stats" option is not passed, user does not care about > the type, just expects any type of stats. > > Examples: ... Series applied, thanks Jiri.