From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, saeedm@mellanox.com,
leon@kernel.org, michael.chan@broadcom.com, vishal@chelsio.com,
jeffrey.t.kirsher@intel.com, idosch@mellanox.com,
aelior@marvell.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, pablo@netfilter.org,
ecree@solarflare.com, mlxsw@mellanox.com
Subject: Re: [patch net-next v3 03/10] flow_offload: check for basic action hw stats type
Date: Mon, 9 Mar 2020 12:17:22 -0700 [thread overview]
Message-ID: <20200309121722.6f536941@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200307065948.GB2210@nanopsycho.orion>
On Sat, 7 Mar 2020 07:59:48 +0100 Jiri Pirko wrote:
> >> +static inline bool
> >> +flow_action_hw_stats_types_check(const struct flow_action *action,
> >> + struct netlink_ext_ack *extack,
> >> + u8 allowed_hw_stats_type)
> >> +{
> >> + const struct flow_action_entry *action_entry;
> >> +
> >> + if (!flow_action_has_entries(action))
> >> + return true;
> >> + if (!flow_action_mixed_hw_stats_types_check(action, extack))
> >> + return false;
> >> + action_entry = flow_action_first_entry_get(action);
> >> + if (!allowed_hw_stats_type &&
> >> + action_entry->hw_stats_type != FLOW_ACTION_HW_STATS_TYPE_ANY) {
> >> + NL_SET_ERR_MSG_MOD(extack, "Driver supports only default HW stats type \"any\"");
> >> + return false;
> >> + } else if (allowed_hw_stats_type &&
> >> + action_entry->hw_stats_type != allowed_hw_stats_type) {
> >
> >Should this be an logical 'and' if we're doing it the bitfield way?
>
> No. I driver passes allowed_hw_stats_type != 0, means that allowed_hw_stats_type
> should be checked against action_entry->hw_stats_type.
Right, the "allowed_hw_stats_type &&" is fine.
> With bitfield, this is a bit awkward, I didn't figure out to do it
> better though.
The bitfield passed from user space means any of the set bits, right?
Condition would be better as:
allowed_hw_stats_type && (allowed_hw_stats_type & entry->hw_stats_type)
Otherwise passing more than one bit will not work well, no?
Driver can pass IMMEDIATE | DELAYED, action has IMMEDIATE, your
condition would reject it.. Same if driver has only one type and user
space asks for any of a few.
Drivers can't do a straight comparisons either, but:
if (act->stats & TYPE1) {
/* preferred stats type*/
} else if (act->stats & TYPE2) {
/* also supported, lower prio */
} else if (act->Stats & TYPE3) {
/* lowest prio */
}
next prev parent reply other threads:[~2020-03-09 19:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 13:28 [patch net-next v3 00/10] net: allow user specify TC action HW stats type Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 01/10] flow_offload: Introduce offload of " Jiri Pirko
2020-03-06 19:23 ` Jakub Kicinski
2020-03-06 13:28 ` [patch net-next v3 02/10] ocelot_flower: use flow_offload_has_one_action() helper Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 03/10] flow_offload: check for basic action hw stats type Jiri Pirko
2020-03-06 19:28 ` Jakub Kicinski
2020-03-07 6:59 ` Jiri Pirko
2020-03-09 19:17 ` Jakub Kicinski [this message]
2020-03-10 10:13 ` Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 04/10] mlxsw: spectrum_flower: Do not allow mixing HW stats types for actions Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 05/10] mlxsw: restrict supported HW stats type to "any" Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 06/10] flow_offload: introduce "immediate" HW stats type and allow it in mlxsw Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 07/10] flow_offload: introduce "delayed" HW stats type and allow it in mlx5 Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 08/10] mlxsw: spectrum_acl: Ask device for rule stats only if counter was created Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 09/10] flow_offload: introduce "disabled" HW stats type and allow it in mlxsw Jiri Pirko
2020-03-06 19:31 ` Jakub Kicinski
2020-03-07 6:56 ` Jiri Pirko
2020-03-09 19:20 ` Jakub Kicinski
2020-03-10 10:14 ` Jiri Pirko
2020-03-06 13:28 ` [patch net-next v3 10/10] sched: act: allow user to specify type of HW stats for a filter Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309121722.6f536941@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=idosch@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=peppe.cavallaro@st.com \
--cc=saeedm@mellanox.com \
--cc=vishal@chelsio.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).