From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
petrm@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 2/6] net: sched: Add centralized RED flag checking
Date: Mon, 9 Mar 2020 15:18:18 -0700 [thread overview]
Message-ID: <20200309151818.4350fae6@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200309183503.173802-3-idosch@idosch.org>
On Mon, 9 Mar 2020 20:34:59 +0200 Ido Schimmel wrote:
> From: Petr Machata <petrm@mellanox.com>
>
> The qdiscs RED, GRED, SFQ and CHOKE use different subsets of the same pool
> of global RED flags. Add a common function for all of these to validate
> that only supported flags are passed. In later patches this function will
> be extended with a check for flag compatibility / meaningfulness.
>
> Signed-off-by: Petr Machata <petrm@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
The commit message should mention this changes behavior of the kernel,
as the flags weren't validated, so buggy user space may start to see
errors.
The only flags which are validated today are the gRED per-vq ones, which
are a recent addition and were validated from day one.
next prev parent reply other threads:[~2020-03-09 22:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:34 [PATCH net-next 0/6] RED: Introduce an ECN tail-dropping mode Ido Schimmel
2020-03-09 18:34 ` [PATCH net-next 1/6] selftests: qdiscs: Add TDC test for RED Ido Schimmel
2020-03-10 15:40 ` Roman Mashak
2020-03-10 16:56 ` Petr Machata
2020-03-10 17:28 ` Roman Mashak
2020-03-09 18:34 ` [PATCH net-next 2/6] net: sched: Add centralized RED flag checking Ido Schimmel
2020-03-09 22:18 ` Jakub Kicinski [this message]
2020-03-10 9:48 ` Petr Machata
2020-03-10 19:53 ` Jakub Kicinski
2020-03-10 22:23 ` Petr Machata
2020-03-10 23:00 ` Jakub Kicinski
2020-03-10 23:53 ` Petr Machata
2020-03-09 18:35 ` [PATCH net-next 3/6] net: sched: RED: Introduce an ECN tail-dropping mode Ido Schimmel
2020-03-09 22:12 ` Jakub Kicinski
2020-03-10 9:48 ` Petr Machata
2020-03-09 18:35 ` [PATCH net-next 4/6] mlxsw: spectrum_qdisc: Offload RED " Ido Schimmel
2020-03-09 18:35 ` [PATCH net-next 5/6] selftests: qdiscs: RED: Add taildrop tests Ido Schimmel
2020-03-09 18:35 ` [PATCH net-next 6/6] selftests: mlxsw: RED: Test RED ECN taildrop offload Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309151818.4350fae6@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).