* [PATCH v2 net] net/smc: cancel event worker during device removal
@ 2020-03-10 8:33 Karsten Graul
2020-03-10 9:31 ` Leon Romanovsky
2020-03-10 22:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Karsten Graul @ 2020-03-10 8:33 UTC (permalink / raw)
To: davem; +Cc: leon, netdev, linux-s390, heiko.carstens, raspl, ubraun
During IB device removal, cancel the event worker before the device
structure is freed.
Fixes: a4cf0443c414 ("smc: introduce SMC as an IB-client")
Reported-by: syzbot+b297c6825752e7a07272@syzkaller.appspotmail.com
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
---
net/smc/smc_ib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c
index d6ba186f67e2..05b825b3cfa4 100644
--- a/net/smc/smc_ib.c
+++ b/net/smc/smc_ib.c
@@ -582,6 +582,7 @@ static void smc_ib_remove_dev(struct ib_device *ibdev, void *client_data)
smc_smcr_terminate_all(smcibdev);
smc_ib_cleanup_per_ibdev(smcibdev);
ib_unregister_event_handler(&smcibdev->event_handler);
+ cancel_work_sync(&smcibdev->port_event_work);
kfree(smcibdev);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net] net/smc: cancel event worker during device removal
2020-03-10 8:33 [PATCH v2 net] net/smc: cancel event worker during device removal Karsten Graul
@ 2020-03-10 9:31 ` Leon Romanovsky
2020-03-10 22:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2020-03-10 9:31 UTC (permalink / raw)
To: Karsten Graul; +Cc: davem, netdev, linux-s390, heiko.carstens, raspl, ubraun
On Tue, Mar 10, 2020 at 09:33:30AM +0100, Karsten Graul wrote:
> During IB device removal, cancel the event worker before the device
> structure is freed.
>
> Fixes: a4cf0443c414 ("smc: introduce SMC as an IB-client")
> Reported-by: syzbot+b297c6825752e7a07272@syzkaller.appspotmail.com
> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
> Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
> ---
> net/smc/smc_ib.c | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net] net/smc: cancel event worker during device removal
2020-03-10 8:33 [PATCH v2 net] net/smc: cancel event worker during device removal Karsten Graul
2020-03-10 9:31 ` Leon Romanovsky
@ 2020-03-10 22:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-03-10 22:41 UTC (permalink / raw)
To: kgraul; +Cc: leon, netdev, linux-s390, heiko.carstens, raspl, ubraun
From: Karsten Graul <kgraul@linux.ibm.com>
Date: Tue, 10 Mar 2020 09:33:30 +0100
> During IB device removal, cancel the event worker before the device
> structure is freed.
>
> Fixes: a4cf0443c414 ("smc: introduce SMC as an IB-client")
> Reported-by: syzbot+b297c6825752e7a07272@syzkaller.appspotmail.com
> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
> Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Applied and queued up for -stable, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-10 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 8:33 [PATCH v2 net] net/smc: cancel event worker during device removal Karsten Graul
2020-03-10 9:31 ` Leon Romanovsky
2020-03-10 22:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).