From: Jakub Kicinski <kuba@kernel.org>
To: sunil.kovvuri@gmail.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Sunil Goutham <sgoutham@marvell.com>,
Tomasz Duszynski <tduszynski@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Christina Jacob <cjacob@marvell.com>
Subject: Re: [PATCH net-next 1/6] octeontx2-pf: Enable SRIOV and added VF mbox handling
Date: Tue, 10 Mar 2020 14:43:34 -0700 [thread overview]
Message-ID: <20200310144334.3fcbd4a8@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <1583866045-7129-2-git-send-email-sunil.kovvuri@gmail.com>
On Wed, 11 Mar 2020 00:17:20 +0530 sunil.kovvuri@gmail.com wrote:
> @@ -1313,6 +1701,61 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return err;
> }
>
> +static int otx2_sriov_enable(struct pci_dev *pdev, int numvfs)
> +{
> + struct net_device *netdev = pci_get_drvdata(pdev);
> + struct otx2_nic *pf = netdev_priv(netdev);
> + int ret;
> +
> + if (numvfs > pf->total_vfs)
> + numvfs = pf->total_vfs;
Core should do this kind of checking for you, please remove.
next prev parent reply other threads:[~2020-03-10 21:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 18:47 [PATCH net-next 0/6] octeontx2-vf: Add network driver for virtual function sunil.kovvuri
2020-03-10 18:47 ` [PATCH net-next 1/6] octeontx2-pf: Enable SRIOV and added VF mbox handling sunil.kovvuri
2020-03-10 21:43 ` Jakub Kicinski [this message]
2020-03-10 18:47 ` [PATCH net-next 2/6] octeontx2-pf: Handle VF function level reset sunil.kovvuri
2020-03-10 21:43 ` Jakub Kicinski
2020-03-10 18:47 ` [PATCH net-next 3/6] octeontx2-vf: Virtual function driver dupport sunil.kovvuri
2020-03-10 21:43 ` Jakub Kicinski
2020-03-11 7:14 ` Sunil Kovvuri
2020-03-11 10:16 ` Leon Romanovsky
2020-03-11 21:24 ` Jakub Kicinski
2020-03-10 18:47 ` [PATCH net-next 4/6] octeontx2-vf: Ethtool support sunil.kovvuri
2020-03-10 19:21 ` Andrew Lunn
2020-03-11 6:39 ` Sunil Kovvuri
2020-03-11 7:05 ` Leon Romanovsky
2020-03-11 7:18 ` Sunil Kovvuri
2020-03-11 10:12 ` Leon Romanovsky
2020-03-10 21:45 ` Jakub Kicinski
2020-03-11 6:40 ` Sunil Kovvuri
2020-03-10 18:47 ` [PATCH net-next 5/6] octeontx2-vf: Link event notification support sunil.kovvuri
2020-03-10 18:47 ` [PATCH net-next 6/6] octeontx2-pf: Cleanup all receive buffers in SG descriptor sunil.kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310144334.3fcbd4a8@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=cjacob@marvell.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sunil.kovvuri@gmail.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).