From: Lukas Wunner <lukas@wunner.de>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, Martin Mares <mj@ucw.cz>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Thomas Graf <tgraf@suug.ch>, Alexei Starovoitov <ast@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH nf-next 3/3] netfilter: Introduce egress hook
Date: Wed, 11 Mar 2020 16:54:51 +0100 [thread overview]
Message-ID: <20200311155451.e3mtgrdvuiujgvs6@wunner.de> (raw)
In-Reply-To: <a57687ae-2da6-ca2a-1c84-e4332a5e4556@iogearbox.net>
On Wed, Mar 11, 2020 at 03:05:16PM +0100, Daniel Borkmann wrote:
> no need to make the fast-path slower for exotic protocols
> which can be solved through other means.
As said the fast-path gets faster, not slower.
> > * Without this commit:
> > Result: OK: 34240933(c34238375+d2558) usec, 100000000 (60byte,0frags)
> > 2920481pps 1401Mb/sec (1401830880bps) errors: 0
> >
> > * With this commit:
> > Result: OK: 33997299(c33994193+d3106) usec, 100000000 (60byte,0frags)
> > 2941410pps 1411Mb/sec (1411876800bps) errors: 0
>
> So you are suggesting that we've just optimized the stack by adding more
> hooks to it ...?
Since I've provided numbers to disprove your allegation, I think the
onus is now on you to prove that your allegation holds any water.
Please reproduce the measurements and let's go from there.
This isn't much work, I've made it really easy by providing all the
steps necessary in the commit message.
Thanks,
Lukas
next prev parent reply other threads:[~2020-03-11 15:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 11:59 [PATCH nf-next 0/3] Netfilter egress hook Lukas Wunner
2020-03-11 11:59 ` [PATCH nf-next 1/3] netfilter: Rename ingress hook include file Lukas Wunner
2020-03-11 11:59 ` [PATCH nf-next 2/3] netfilter: Generalize ingress hook Lukas Wunner
2020-03-11 11:59 ` [PATCH nf-next 3/3] netfilter: Introduce egress hook Lukas Wunner
2020-03-11 14:05 ` Daniel Borkmann
2020-03-11 15:54 ` Lukas Wunner [this message]
2020-03-12 22:40 ` Daniel Borkmann
2020-03-13 14:55 ` Pablo Neira Ayuso
2020-03-14 0:12 ` Daniel Borkmann
2020-03-15 13:28 ` Pablo Neira Ayuso
2020-04-23 14:44 ` Laura Garcia
2020-04-23 16:05 ` Lukas Wunner
2020-04-27 23:44 ` Pablo Neira Ayuso
2020-04-28 20:11 ` Daniel Borkmann
2020-08-20 10:37 ` Lukas Wunner
2020-08-20 16:35 ` Lukas Wunner
2020-03-18 0:21 ` [PATCH nf-next 0/3] Netfilter " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311155451.e3mtgrdvuiujgvs6@wunner.de \
--to=lukas@wunner.de \
--cc=0x7f454c46@gmail.com \
--cc=ast@kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=mj@ucw.cz \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).