From: Kees Cook <keescook@chromium.org>
To: David Miller <davem@davemloft.net>
Cc: kuba@kernel.org, shuah@kernel.org, luto@amacapital.net,
wad@chromium.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v2 0/4] kselftest: add fixture parameters
Date: Sun, 15 Mar 2020 13:55:48 -0700 [thread overview]
Message-ID: <202003151355.C9118025F@keescook> (raw)
In-Reply-To: <20200315.000517.641109897419327751.davem@davemloft.net>
On Sun, Mar 15, 2020 at 12:05:17AM -0700, David Miller wrote:
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Fri, 13 Mar 2020 17:54:57 -0700
>
> > This set is an attempt to make running tests for different
> > sets of data easier. The direct motivation is the tls
> > test which we'd like to run for TLS 1.2 and TLS 1.3,
> > but currently there is no easy way to invoke the same
> > tests with different parameters.
> >
> > Tested all users of kselftest_harness.h.
> >
> > v2:
> > - don't run tests by fixture
> > - don't pass params as an explicit argument
> >
> > Note that we loose a little bit of type safety
> > without passing parameters as an explicit argument.
> > If user puts the name of the wrong fixture as argument
> > to CURRENT_FIXTURE() it will happily cast the type.
>
> Hmmm, what tree should integrate this patch series?
I expect the final version (likely v3) to go via Shuah's selftest tree.
-Kees
--
Kees Cook
prev parent reply other threads:[~2020-03-15 20:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 0:54 [PATCH v2 0/4] kselftest: add fixture parameters Jakub Kicinski
2020-03-14 0:54 ` [PATCH v2 1/4] selftests/seccomp: use correct FIXTURE macro Jakub Kicinski
2020-03-14 0:54 ` [PATCH v2 2/4] kselftest: create fixture objects Jakub Kicinski
2020-03-14 0:55 ` [PATCH v2 3/4] kselftest: add fixture parameters Jakub Kicinski
2020-03-14 0:55 ` [PATCH v2 4/4] selftests: tls: run all tests for TLS 1.2 and TLS 1.3 Jakub Kicinski
2020-03-14 4:41 ` [PATCH v2 0/4] kselftest: add fixture parameters Kees Cook
2020-03-16 15:55 ` Bird, Tim
2020-03-16 20:04 ` Jakub Kicinski
2020-03-16 21:01 ` Kees Cook
2020-03-16 21:27 ` Jakub Kicinski
2020-03-15 7:05 ` David Miller
2020-03-15 20:55 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003151355.C9118025F@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).